third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html - Issue 2730123003: [Presentation API] Add layout test for connection.close() and fix test failures

Side by Side Diff: third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html

Issue 2730123003: [Presentation API] Add layout test for connection.close() and fix test failures (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/renderer/presentation/presentation_connection_proxy.cc ('K') | « content/renderer/presentation/test_presentation_connection.h ('k') | third_party/WebKit/LayoutTests/presentation/presentation-controller-connection-closed-by-receiver.html » ('j') | third_party/WebKit/public/platform/modules/presentation/WebPresentationConnection.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script src="../resources/mojo-helpers.js"></script>

	7 <script src="resources/presentation-service-mock.js"></script>

	8 <button>click me</button>

	9 <script>

	10

	11 var button = document.querySelector('button');

	12 var receiverConnectionClosed = false;

	13 var connection = null;

	14

	15 async_test(t => {

	16 presentationServiceMock.then(service => {

	17 // This is receiving the user gesture and runs the callback.

	18 waitForClick(() => {

	19 new PresentationRequest("http://example.com/").start().then(
	mark a. foltz 2017/03/06 18:57:55 Nit: Use https: to reflect upcoming deprecation on Nit: Use https: to reflect upcoming deprecation on insecure contexts. zhaobin 2017/03/06 19:52:23 Done. Show quoted text On 2017/03/06 18:57:55, mark a. foltz wrote: > Nit: Use https: to reflect upcoming deprecation on insecure contexts. Done.
	20 theConnection => {

	21 connection = theConnection;

	22 connection.onclose = () => {

	23 assert_equals(connection.state, "closed");
	imcheng 2017/03/04 00:58:28 Is there a specific reason / message we should be Is there a specific reason / message we should be asserting here and in the other test cases? mark a. foltz 2017/03/06 18:57:55 The message is only required for the "error" close Show quoted text On 2017/03/04 at 00:58:28, imcheng wrote: > Is there a specific reason / message we should be asserting here and in the other test cases? The message is only required for the "error" close event reason - I don't think it would add much to the other close reasons, we can add one later if there is something I'm missing. This test could assert an empty close message just to define the behavior. Here's the spec language covering the close event message. https://w3c.github.io/presentation-api/#sending-a-message-through-presentatio... zhaobin 2017/03/06 19:52:23 Done. Show quoted text On 2017/03/06 18:57:55, mark a. foltz wrote: > On 2017/03/04 at 00:58:28, imcheng wrote: > > Is there a specific reason / message we should be asserting here and in the > other test cases? > > The message is only required for the "error" close event reason - I don't think > it would add much to the other close reasons, we can add one later if there is > something I'm missing. > > This test could assert an empty close message just to define the behavior. > > Here's the spec language covering the close event message. > https://w3c.github.io/presentation-api/#sending-a-message-through-presentatio... Done.
	24 assert_true(receiverConnectionClosed);

	25 t.done();

	26 };

	27 connection.onconnect = () => {

	28 // Open a receiver page and pass controller connection's

	29 // controllerConnectionPtr and receiverConnectionRequest to it.

	30 w = window.open("resources/presentation-receiver-close-connection.ht ml");

	31 w.controllerConnectionPtr = service.getControllerConnectionPtr();

	32 w.receiverConnectionRequest = service.getReceiverConnectionRequest() ;

	33 w.shouldCallClose = false;

	34 };

	35 });

	36 }, button);

	37 });

	38

	39 window.addEventListener("message", t.step_func(e => {

	40 if (e.data == "receiver connection closed") {

	41 receiverConnectionClosed = true;

	42 } else if (e.data == "receiver connection ready") {

	43 assert_not_equals(connection, null);

	44 connection.close();

	45 }

	46 }));

	47 }, "controller connection.close() should fire both controller's and receiver's o nclose event handler");

	48

	49 </script>

	50 </body>

	51 </html>

OLD	NEW