Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2730093002: Avoid crashing on function syntax. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry, karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add TODO. #

Patch Set 3 : Update status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -21 lines) Patch
M pkg/front_end/lib/src/fasta/builder/builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/lib/src/fasta/builder/function_type_builder.dart View 1 chunk +43 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/named_type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A pkg/front_end/lib/src/fasta/kernel/kernel_function_type_builder.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +12 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 1 chunk +37 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/kompile.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/outline.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/type_variable_as_super.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/language/language_kernel.status View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/patch_sdk.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 9 months ago (2017-03-03 16:17:23 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-07 11:30:05 UTC) #3
ahe
3 years, 9 months ago (2017-03-07 15:54:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2934dfaf165d594d8b72906dd3a34d909828096b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698