Mac/clang: Uncontentious fixes.

Mac/clang: Uncontentious fixes.

* Remove unused variables
* Make types in h and cc files agree
* Use subclasses if we call subclass methods
* Fix one real bug (`if (a); a->foo()`)
* Fix forward declarations to be correct
* Don't mark some definitions with "extern"

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49570

[Nico, 2010-06-11 18:24:28]

I didn't touch 'extern const NSString* foo = @"foo";' yet 'cause that needs
more, possibly contentious, changes.

http://codereview.chromium.org/2730015/diff/1/7
File chrome/browser/cocoa/bookmark_editor_base_controller.mm (left):

http://codereview.chromium.org/2730015/diff/1/7#oldcode23
chrome/browser/cocoa/bookmark_editor_base_controller.mm:23: @property (retain,
readwrite) NSArray* folderTreeArray;
Already declared in the h file

http://codereview.chromium.org/2730015/diff/1/16
File chrome/browser/cocoa/menu_controller.mm (right):

http://codereview.chromium.org/2730015/diff/1/16#newcode145
chrome/browser/cocoa/menu_controller.mm:145: model->ActivatedAt(modelIndex);
!

[Mark Mentovai - out til August, 2010-06-11 18:47:35]

LGTM. Good stuff.

Make sure it’s been tested with the current toolchain too.

http://codereview.chromium.org/2730015/diff/2001/3005
File chrome/browser/cocoa/bookmark_button.h (right):

http://codereview.chromium.org/2730015/diff/2001/3005#newcode12
chrome/browser/cocoa/bookmark_button.h:12: struct BookmarkDragData;
Oh, clang considers class/structness? How very MSVC++-esque.

http://codereview.chromium.org/2730015/diff/2001/3007
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/2730015/diff/2001/3007#newcode1481
chrome/browser/cocoa/browser_window_controller.mm:1481: // TODO(pinkerton):
figure out page-up, http://crbug.com/16305
Wow.

http://codereview.chromium.org/2730015/diff/2001/3015
File chrome/browser/cocoa/menu_controller.mm (right):

http://codereview.chromium.org/2730015/diff/2001/3015#newcode144
chrome/browser/cocoa/menu_controller.mm:144: if (model)
ha!