Issue 2730014: Avoids sending about: URLs to DOM UI renderers in process-per-tab....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2730014: Avoids sending about: URLs to DOM UI renderers in process-per-tab.... (Closed)

Created:
10 years, 6 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, Peter Kasting

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Avoids sending about: URLs to DOM UI renderers in process-per-tab. Since about:version, etc get translated to chrome://about/version, we were sending them to a DOM UI renderer in process-per-tab mode. This hit a CHECK where we ensured non-DOM-UI URLs weren't sent to such renderers. BUG=46290 TEST=RenderViewHostManagerTest.NonDOMUIChromeURLs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49603

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -3 lines)			Patch
M	chrome/browser/tab_contents/render_view_host_manager.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_manager_unittest.cc	View	4 chunks	+37 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages