Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2730014: Avoids sending about: URLs to DOM UI renderers in process-per-tab.... (Closed)

Created:
10 years, 6 months ago by Charlie Reis
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, Peter Kasting
Visibility:
Public.

Description

Avoids sending about: URLs to DOM UI renderers in process-per-tab. Since about:version, etc get translated to chrome://about/version, we were sending them to a DOM UI renderer in process-per-tab mode. This hit a CHECK where we ensured non-DOM-UI URLs weren't sent to such renderers. BUG=46290 TEST=RenderViewHostManagerTest.NonDOMUIChromeURLs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M chrome/browser/tab_contents/render_view_host_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_manager_unittest.cc View 4 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Charlie Reis
10 years, 6 months ago (2010-06-11 17:53:09 UTC) #1
brettw
10 years, 6 months ago (2010-06-11 20:49:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698