Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2729943004: Remove backend reference from ResolutionEnqueuerListener. (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove backend reference from ResolutionEnqueuerListener. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/28f7099f17a3f885de84b03a7bb4e11e3ec0c766

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -34 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +10 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 5 chunks +5 lines, -1 line 2 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 8 chunks +8 lines, -21 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 3 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-03 15:46:33 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2729943004/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart File pkg/compiler/lib/src/js_backend/interceptor_data.dart (right): https://codereview.chromium.org/2729943004/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart#newcode220 pkg/compiler/lib/src/js_backend/interceptor_data.dart:220: final Resolution _resolution; any chance that we are ...
3 years, 9 months ago (2017-03-14 03:35:18 UTC) #3
Johnni Winther
https://codereview.chromium.org/2729943004/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart File pkg/compiler/lib/src/js_backend/interceptor_data.dart (right): https://codereview.chromium.org/2729943004/diff/1/pkg/compiler/lib/src/js_backend/interceptor_data.dart#newcode220 pkg/compiler/lib/src/js_backend/interceptor_data.dart:220: final Resolution _resolution; On 2017/03/14 03:35:17, Siggi Cherem (dart-lang) ...
3 years, 9 months ago (2017-03-15 10:10:20 UTC) #4
Johnni Winther
3 years, 9 months ago (2017-03-15 10:17:33 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
28f7099f17a3f885de84b03a7bb4e11e3ec0c766 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698