Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2729813004: Fixes issue #28904 and issue #28901. Fixed an out of range array access in the hash map Iterator::N… (Closed)

Created:
3 years, 9 months ago by bkonyi
Modified:
3 years, 9 months ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes issue #28904 and issue #28901. Fixed an out of range array access in the hash map Iterator::Next() method which was causing occasional crashes in tests. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/ed3322c4507842337ee46fe8c89691a52456ea63

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added parens around boolean expression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/hash_map.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 9 months ago (2017-03-03 02:03:53 UTC) #2
zra
lgtm! good catch! https://codereview.chromium.org/2729813004/diff/1/runtime/vm/hash_map.h File runtime/vm/hash_map.h (right): https://codereview.chromium.org/2729813004/diff/1/runtime/vm/hash_map.h#newcode178 runtime/vm/hash_map.h:178: while (array_index_ < map_.array_size_ && Please ...
3 years, 9 months ago (2017-03-03 18:03:54 UTC) #3
bkonyi
3 years, 9 months ago (2017-03-03 18:37:30 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ed3322c4507842337ee46fe8c89691a52456ea63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698