Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 27298: Attempt 2 at landing this.... (Closed)

Created:
11 years, 10 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Attempt 2 at landing this. Don't call SetPriorityClass if CBSText.dll is loaded in the browser process. The CBSText.dll loads as a global GetMessage hook into the browser process and intercepts/unintercepts the kernel32 API SetPriorityClass in a background thread. If the browser calls this API just when it is intercepted the dlls interceptor proc messes up the stack while returning back, which causes random crashes in the browser. The hacky fix for now is to check for this dll and not invoke the API. We will beautify this fix if it works in the wild. This fixes http://code.google.com/p/chromium/issues/detail?id=6418 Bug=6418 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10676

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
11 years, 10 months ago (2009-02-28 00:12:07 UTC) #1
cpu_(ooo_6.6-7.5)
11 years, 10 months ago (2009-02-28 00:14:07 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698