third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js - Issue 2729793003: DevTools: Support reading CPU profile format on Performance panel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 2729793003: DevTools: Support reading CPU profile format on Performance panel (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js » ('j') | third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

index ac9d88f8f937c58723b11e05f74b772fb6327dce..78ba98d6e753b314ec03373f07f7d4d7a4d78c65 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js

@@ -697,8 +697,7 @@ Timeline.TimelineFlameChartDataProvider = class {

event.duration || Timeline.TimelineFlameChartDataProvider.InstantEventVisibleDurationMs;

this._timelineData.entryStartTimes[index] = event.startTime;

var initiator = TimelineModel.TimelineData.forEvent(event).initiator();

- if (initiator &&

- (initiator.endTime || initiator.startTime) < event.startTime &&

+ if (initiator && (initiator.endTime || initiator.startTime) < event.startTime &&

caseq 2017/03/02 19:00:40 revert?

alph 2017/03/02 19:20:00 Done.

initiator.name !== 'ResourceSendRequest') {

var initiatorIndex = initiator[Timeline.TimelineFlameChartDataProvider._eventIndexSymbol];

if (initiatorIndex === undefined)