Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2729773004: Make observatory 'pub serve' work again in Dartium (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make observatory 'pub serve' work again in Dartium pub serve in runtime/observatory with Dartium seems to have been broken since c8e275537dd9288a423c3a432d417379a49c6a4a. When I try to make observatory connect I just get a blank page. If I open Dartiums console I get a *long* stacktrace saying "Caught exception: String Expected". BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/1ba39faa3f2c5b1c13774939a925018ef537efbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/observatory/lib/src/elements/vm_view.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 years, 9 months ago (2017-03-02 14:39:54 UTC) #2
Kevin Millikin (Google)
LGTM. Someone should probably look at the the other Analyzer warnings in Observatory and make ...
3 years, 9 months ago (2017-03-06 13:23:54 UTC) #3
jensj
3 years, 9 months ago (2017-03-07 07:21:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ba39faa3f2c5b1c13774939a925018ef537efbe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698