Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: components/offline_pages/core/background/request_coordinator_unittest.cc

Issue 2729763002: [Offline Pages] Pick correct request when resuming. (Closed)
Patch Set: nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/core/background/request_coordinator_unittest.cc b/components/offline_pages/core/background/request_coordinator_unittest.cc
index 753dd8831ec926611a310b79210d4a23f228c117..d6a0443ddeaa8fd84a7aa9513723970a9dc44828 100644
--- a/components/offline_pages/core/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/core/background/request_coordinator_unittest.cc
@@ -296,6 +296,10 @@ class RequestCoordinatorTest : public testing::Test {
return coordinator()->disabled_requests_;
}
+ const std::deque<int64_t>& prioritized_requests() {
+ return coordinator()->prioritized_requests_;
+ }
+
private:
GetRequestsResult last_get_requests_result_;
MultipleItemStatuses last_remove_results_;
@@ -1436,10 +1440,12 @@ TEST_F(RequestCoordinatorTest,
coordinator()->ResumeRequests(request_ids);
PumpLoop();
EXPECT_FALSE(is_busy());
+ EXPECT_EQ(1UL, prioritized_requests().size());
// Pause the request again.
coordinator()->PauseRequests(request_ids);
PumpLoop();
+ EXPECT_EQ(0UL, prioritized_requests().size());
// Now simulate reasonable connection.
SetNetworkConnected(true);
@@ -1448,6 +1454,7 @@ TEST_F(RequestCoordinatorTest,
coordinator()->ResumeRequests(request_ids);
EXPECT_FALSE(is_busy());
PumpLoop();
+ EXPECT_EQ(1UL, prioritized_requests().size());
EXPECT_TRUE(is_busy());
}

Powered by Google App Engine
This is Rietveld 408576698