Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/offline_pages/core/background/request_coordinator.h

Issue 2729763002: [Offline Pages] Pick correct request when resuming. (Closed)
Patch Set: nit Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator.h
diff --git a/components/offline_pages/core/background/request_coordinator.h b/components/offline_pages/core/background/request_coordinator.h
index 770cae3a8f1cd7595a44091e120efbc01741d914..38904c07f6bd5138611a002aa77b05f90e67883f 100644
--- a/components/offline_pages/core/background/request_coordinator.h
+++ b/components/offline_pages/core/background/request_coordinator.h
@@ -452,6 +452,15 @@ class RequestCoordinator : public KeyedService,
base::OneShotTimer watchdog_timer_;
// Used for potential immediate processing when we get network connection.
std::unique_ptr<ConnectionNotifier> connection_notifier_;
+ // Used to track prioritized requests.
+ // The requests can only be added by RC when they are resumed and there are
+ // two places where deletion from the |prioritized_requests_| would happen:
+ // 1. When request is paused RC will remove it.
+ // 2. When a task is not available to be picked by PickRequestTask (because
+ // it was completed or cancelled), the task will remove it.
+ // Currently it's used as LIFO.
+ // TODO(romax): see if LIFO is a good idea, or change to FIFO.
+ std::deque<int64_t> prioritized_requests_;
// Allows us to pass a weak pointer to callbacks.
base::WeakPtrFactory<RequestCoordinator> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698