Handle resize in PaintPropertyTreeBuilder::updateForObjectSizeAndLocation()

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/PaintPropertyTreeBuilder.h"
 
 #include <memory>
 #include "core/dom/DOMNodeIds.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
@@ skipping 1025 matching lines @@
     // Similar adjustment is done in LayoutTableCell::offsetFromContainer().
     if (object.isTableCell()) {
       LayoutObject* parentRow = object.parent();
       DCHECK(parentRow && parentRow->isTableRow());
       context.current.paintOffset.moveBy(
           -toLayoutBox(parentRow)->physicalLocation());
     }
   }
 }
 
-void PaintPropertyTreeBuilder::updateForObjectLocation(
+void PaintPropertyTreeBuilder::updateForObjectSizeAndLocation(
     const LayoutObject& object,
     PaintPropertyTreeBuilderContext& context) {
   if (object.isBoxModelObject()) {
     updatePaintOffset(toLayoutBoxModelObject(object), context);
     updatePaintOffsetTranslation(toLayoutBoxModelObject(object), context);
   }
 
-  if (object.paintOffset() == context.current.paintOffset)
-    return;
+  if (object.isBox()) {
+    const LayoutBox& box = toLayoutBox(object);
+    if (box.size() != box.previousSize() &&
+        // The overflow clip paint property depends on the border box rect
+        // through overflowClipRect(). The border box rect's size equals the
+        // frame rect's size so we trigger a paint property update when the
+        // frame rect changes.
+        (box.shouldClipOverflow() ||
+         // The used value of CSS clip may depend on size of the box, e.g.
+         // for clip: rect(auto auto auto -5px).
+         box.hasClip() ||
+         // Relative lengths (e.g., percentage values) in transform,
+         // perspective, transform-origin, and perspective-origin can depend on
+         // the size of the frame rect, so force a property update if it
+         // changes. TODO(pdr): We only need to update properties if there are
+         // relative lengths.
+         box.styleRef().hasTransform() || box.styleRef().hasPerspective()))
+      box.getMutableForPainting().setNeedsPaintPropertyUpdate();
+  }
 
-  // Many paint properties depend on paint offset so we force an update of
-  // the entire subtree on paint offset changes.
-  context.forceSubtreeUpdate = true;
+  if (object.paintOffset() != context.current.paintOffset) {
+    // Many paint properties depend on paint offset so we force an update of
+    // the entire subtree on paint offset changes.
+    context.forceSubtreeUpdate = true;
 
-  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
-    object.getMutableForPainting().setShouldDoFullPaintInvalidation(
-        PaintInvalidationLocationChange);
+    if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+      object.getMutableForPainting().setShouldDoFullPaintInvalidation(
+          PaintInvalidationLocationChange);
+    }
+    object.getMutableForPainting().setPaintOffset(context.current.paintOffset);
   }
-  object.getMutableForPainting().setPaintOffset(context.current.paintOffset);
 }
 
 void PaintPropertyTreeBuilder::updatePropertiesForSelf(
     const LayoutObject& object,
     PaintPropertyTreeBuilderContext& context) {
   // This is not in FindObjectPropertiesNeedingUpdateScope because paint offset
   // can change without needsPaintPropertyUpdate.

[pdr., 2017/03/01 23:38:38]

Nit: can you mention size changing in this comment?

-  updateForObjectLocation(object, context);
+  updateForObjectSizeAndLocation(object, context);
 
 #if DCHECK_IS_ON()
   FindObjectPropertiesNeedingUpdateScope checkNeedsUpdateScope(object, context);
 #endif
 
   if (object.isBoxModelObject() || object.isSVG()) {
     updateTransform(object, context);
     if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
       updateEffect(object, context);
       updateFilter(object, context);
@@ skipping 18 matching lines @@
   updateOverflowClip(object, context);
   updatePerspective(object, context);
   updateSvgLocalToBorderBoxTransform(object, context);
   updateScrollAndScrollTranslation(object, context);
   updateOutOfFlowContext(object, context);
 
   context.forceSubtreeUpdate |= object.subtreeNeedsPaintPropertyUpdate();
 }
 
 }  // namespace blink