Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2729613008: [instrumentation] Introduce InspectorTraceEvents agent (Closed)
Patch Set: . Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 2f1df5b1efa90b09e958bc500182999cd0381405..354b56ad973ed8f849b7fccee779a69acfa24684 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -30,6 +30,9 @@
#include "web/WebDevToolsAgentImpl.h"
+#include <v8-inspector.h>
+#include <memory>
+
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/V8Binding.h"
#include "core/InstrumentingAgents.h"
@@ -89,8 +92,6 @@
#include "wtf/Noncopyable.h"
#include "wtf/PtrUtil.h"
#include "wtf/text/WTFString.h"
-#include <memory>
-#include <v8-inspector.h>
namespace blink {
@@ -356,6 +357,8 @@ void WebDevToolsAgentImpl::initializeSession(int sessionId,
m_tracingAgent = tracingAgent;
m_session->append(tracingAgent);
+ m_session->append(new InspectorTraceEvents());
pfeldman 2017/03/06 23:31:24 Do you want it earlier?
alph 2017/03/07 00:57:48 Done.
+
m_session->append(new InspectorDOMDebuggerAgent(isolate, m_domAgent,
m_session->v8Session()));

Powered by Google App Engine
This is Rietveld 408576698