third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py - Issue 2729613008: [instrumentation] Introduce InspectorTraceEvents agent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

Issue 2729613008: [instrumentation] Introduce InspectorTraceEvents agent (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt ('k') | third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl » ('j') | third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

index 7a4cea791a18431f36b886b78da096b4d1573f23..8795f38f5efc3328cde9494f3d1775686498e4e0 100755

--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInstrumentation.py

@@ -429,6 +429,8 @@ def generate_member_init(param):

def agent_class_name(agent):

if agent == "Performance":

return "PerformanceMonitor"

+ if agent == "Timeline":

+ return "InspectorTraceEvents"

pfeldman 2017/03/06 23:31:24 Just use TraceEvents as a name with no special-cas

alph 2017/03/07 00:57:48 Done.

return "Inspector%sAgent" % agent