Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.h

Issue 2729613007: Fixing a crash in MediaCustomControlsFullscreenDetector when the page is destroyed (Closed)
Patch Set: rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // ImageBitmapSource implementation 116 // ImageBitmapSource implementation
117 IntSize bitmapSourceSize() const override; 117 IntSize bitmapSourceSize() const override;
118 ScriptPromise createImageBitmap(ScriptState*, 118 ScriptPromise createImageBitmap(ScriptState*,
119 EventTarget&, 119 EventTarget&,
120 Optional<IntRect> cropRect, 120 Optional<IntRect> cropRect,
121 const ImageBitmapOptions&, 121 const ImageBitmapOptions&,
122 ExceptionState&) override; 122 ExceptionState&) override;
123 123
124 private: 124 private:
125 friend class MediaCustomControlsFullscreenDetectorTest; 125 friend class MediaCustomControlsFullscreenDetectorTest;
126 friend class HTMLMediaElementEventListenersTest;
126 127
127 HTMLVideoElement(Document&); 128 HTMLVideoElement(Document&);
128 129
129 bool layoutObjectIsNeeded(const ComputedStyle&) override; 130 bool layoutObjectIsNeeded(const ComputedStyle&) override;
130 LayoutObject* createLayoutObject(const ComputedStyle&) override; 131 LayoutObject* createLayoutObject(const ComputedStyle&) override;
131 void attachLayoutTree(const AttachContext& = AttachContext()) override; 132 void attachLayoutTree(const AttachContext& = AttachContext()) override;
132 void parseAttribute(const AttributeModificationParams&) override; 133 void parseAttribute(const AttributeModificationParams&) override;
133 bool isPresentationAttribute(const QualifiedName&) const override; 134 bool isPresentationAttribute(const QualifiedName&) const override;
134 void collectStyleForPresentationAttribute(const QualifiedName&, 135 void collectStyleForPresentationAttribute(const QualifiedName&,
135 const AtomicString&, 136 const AtomicString&,
136 MutableStylePropertySet*) override; 137 MutableStylePropertySet*) override;
137 bool isURLAttribute(const Attribute&) const override; 138 bool isURLAttribute(const Attribute&) const override;
138 const AtomicString imageSourceURL() const override; 139 const AtomicString imageSourceURL() const override;
139 140
140 void updateDisplayState() override; 141 void updateDisplayState() override;
141 void didMoveToNewDocument(Document& oldDocument) override; 142 void didMoveToNewDocument(Document& oldDocument) override;
142 void setDisplayMode(DisplayMode) override; 143 void setDisplayMode(DisplayMode) override;
143 144
144 Member<HTMLImageLoader> m_imageLoader; 145 Member<HTMLImageLoader> m_imageLoader;
145 Member<MediaCustomControlsFullscreenDetector> 146 Member<MediaCustomControlsFullscreenDetector>
146 m_customControlsFullscreenDetector; 147 m_customControlsFullscreenDetector;
147 148
148 AtomicString m_defaultPosterURL; 149 AtomicString m_defaultPosterURL;
149 }; 150 };
150 151
151 } // namespace blink 152 } // namespace blink
152 153
153 #endif // HTMLVideoElement_h 154 #endif // HTMLVideoElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698