Cleanup registration of closures

Cleanup registration of closures

+ split methods and local functions in rti.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/916ec8abbb81a874f11262646cbd4c01d10c0941

[Johnni Winther, 2017-03-02 16:57:36]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-03-14 03:02:34]

lgtm

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:116: /// Called to register that a member has
been closurized. Any backend specific
a member => [member]

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/resolution_world_builder.dart (right):

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:12: /// Set of
(live) local functions (closures) whose signatures reference type
Just to be sure: this is only for RTI and so it includes functions that mention
a free <T> in the argument types or return type? (and will not include a closure
that has a free type-variable in the body), correct?

For example in:

class A<T> {
  m() {
    void localFunction() { return T; }
  }
}

localFunction will not be added here, right?


The name of the field is a bit ambiguous in terms of this. adding "signature" to
the name will just make it so long that it's not worth adding it there, but it
might be worth thinking of other ideas. I don't have any good ones at the moment
:(

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:20: /// A local
function is considered live if the enclosing member function is
nit: add extra line to divide the paragraph

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:28: /// A `call`
method is considered live if the enclosing class has been
`call` method => closurized member

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:316: /// A local
function is considered live if the enclosing member function is
\n

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:326: /// A `call`
method is considered live if the enclosing class has been
`call` method => closurized member

[Johnni Winther, 2017-03-14 16:59:09]

Description was changed from

==========
Cleanup registration of closures

+ split methods and local functions in rti.
==========

to

==========
Cleanup registration of closures

+ split methods and local functions in rti.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/916ec8abbb81a874f11262646cbd4c01d10c0941
==========

[Johnni Winther, 2017-03-14 16:59:10]

Committed patchset #2 (id:20001) manually as
916ec8abbb81a874f11262646cbd4c01d10c0941 (presubmit successful).

[Johnni Winther, 2017-03-14 16:59:46]

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:116: /// Called to register that a member has
been closurized. Any backend specific
On 2017/03/14 03:02:34, Siggi Cherem (dart-lang) wrote:
> a member => [member]

Done.

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/resolution_world_builder.dart (right):

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:12: /// Set of
(live) local functions (closures) whose signatures reference type
On 2017/03/14 03:02:34, Siggi Cherem (dart-lang) wrote:
> Just to be sure: this is only for RTI and so it includes functions that
mention
> a free <T> in the argument types or return type? (and will not include a
closure
> that has a free type-variable in the body), correct?
> 
> For example in:
> 
> class A<T> {
>   m() {
>     void localFunction() { return T; }
>   }
> }
> 
> localFunction will not be added here, right?
> 
> 
Yes

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:20: /// A local
function is considered live if the enclosing member function is
On 2017/03/14 03:02:34, Siggi Cherem (dart-lang) wrote:
> nit: add extra line to divide the paragraph

Duplicate paragraph, removed.

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:28: /// A `call`
method is considered live if the enclosing class has been
On 2017/03/14 03:02:34, Siggi Cherem (dart-lang) wrote:
> `call` method => closurized member

Done.

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:316: /// A local
function is considered live if the enclosing member function is
On 2017/03/14 03:02:34, Siggi Cherem (dart-lang) wrote:
> \n

Done.

https://codereview.chromium.org/2729613004/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/resolution_world_builder.dart:326: /// A `call`
method is considered live if the enclosing class has been
On 2017/03/14 03:02:34, Siggi Cherem (dart-lang) wrote:
> `call` method => closurized member

Done.