Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2729563003: Dismiss popups on Tab deselected (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/chrome/browser/ui/browser_view_controller.h" 5 #import "ios/chrome/browser/ui/browser_view_controller.h"
6 6
7 #import <AssetsLibrary/AssetsLibrary.h> 7 #import <AssetsLibrary/AssetsLibrary.h>
8 #import <MobileCoreServices/MobileCoreServices.h> 8 #import <MobileCoreServices/MobileCoreServices.h>
9 #import <PassKit/PassKit.h> 9 #import <PassKit/PassKit.h>
10 #import <Photos/Photos.h> 10 #import <Photos/Photos.h>
(...skipping 3822 matching lines...) Expand 10 before | Expand all | Expand 10 after
3833 } 3833 }
3834 3834
3835 #pragma mark - Command Handling 3835 #pragma mark - Command Handling
3836 3836
3837 - (IBAction)chromeExecuteCommand:(id)sender { 3837 - (IBAction)chromeExecuteCommand:(id)sender {
3838 NSInteger command = [sender tag]; 3838 NSInteger command = [sender tag];
3839 3839
3840 if (!_model || !_browserState) 3840 if (!_model || !_browserState)
3841 return; 3841 return;
3842 3842
3843 [self dismissPopups];
marq (ping after 24h) 2017/03/02 06:07:40 I can't verify that this is correct. What are all
3844
3843 switch (command) { 3845 switch (command) {
3844 case IDC_BACK: 3846 case IDC_BACK:
3845 [[_model currentTab] goBack]; 3847 [[_model currentTab] goBack];
3846 break; 3848 break;
3847 case IDC_BOOKMARK_PAGE: 3849 case IDC_BOOKMARK_PAGE:
3848 [self initializeBookmarkInteractionController]; 3850 [self initializeBookmarkInteractionController];
3849 [_bookmarkInteractionController 3851 [_bookmarkInteractionController
3850 presentBookmarkForTab:[_model currentTab] 3852 presentBookmarkForTab:[_model currentTab]
3851 currentlyBookmarked:_toolbarModelIOS->IsCurrentTabBookmarkedByUser() 3853 currentlyBookmarked:_toolbarModelIOS->IsCurrentTabBookmarkedByUser()
3852 inView:[_toolbarController bookmarkButtonView] 3854 inView:[_toolbarController bookmarkButtonView]
(...skipping 1172 matching lines...) Expand 10 before | Expand all | Expand 10 after
5025 5027
5026 - (UIView*)voiceSearchButton { 5028 - (UIView*)voiceSearchButton {
5027 return _voiceSearchButton; 5029 return _voiceSearchButton;
5028 } 5030 }
5029 5031
5030 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner { 5032 - (id<LogoAnimationControllerOwner>)logoAnimationControllerOwner {
5031 return [self currentLogoAnimationControllerOwner]; 5033 return [self currentLogoAnimationControllerOwner];
5032 } 5034 }
5033 5035
5034 @end 5036 @end
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698