Make command buffer generator infer GL array element type from the GL prototype

Make command buffer generator infer GL array element type from the GL prototype

Make command buffer generator infer GL array element type from the GL
prototype. Before, it was written in the function info specification.

This would simplify the usage if PUT functions that have two pointer
types would ever be supported.

BUG=344330
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269914

[Kimmo Kinnunen, 2014-05-09 07:40:55]

This could be useful for autogen'ing path rendering commands, if we ever get
there. Should not bother much the existing functionality, either?

[vmiura, 2014-05-09 18:32:22]

LGTM with minor nits.  Adding OWNERS for LGTM.

https://codereview.chromium.org/272953002/diff/1/gpu/command_buffer/build_gle...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/272953002/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:6129: 
nit: Can we make it more robust with a regex?

  match = re.match('(const\s+)?(?P<basetype>[\w]+)\s*\*', self.type)
  assert match
  return match.groupdict()['basetype']

https://codereview.chromium.org/272953002/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:6209: 
nit: same as above.

[piman, 2014-05-09 19:57:22]

lgtm

[Zhenyao Mo, 2014-05-09 21:21:14]

LGTM

[Kimmo Kinnunen, 2014-05-12 10:31:44]

https://codereview.chromium.org/272953002/diff/1/gpu/command_buffer/build_gle...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/272953002/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:6129: 
On 2014/05/09 18:32:23, vmiura wrote:
> nit: Can we make it more robust with a regex?
> 
>   match = re.match('(const\s+)?(?P<basetype>[\w]+)\s*\*', self.type)
>   assert match
>   return match.groupdict()['basetype']

Done.

https://codereview.chromium.org/272953002/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:6209: 
On 2014/05/09 18:32:23, vmiura wrote:
> nit: same as above.

Done.

[Kimmo Kinnunen, 2014-05-12 10:32:09]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-05-12 10:32:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/272953002/20001

[commit-bot: I haz the power, 2014-05-12 12:23:02]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-12 13:41:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-12 13:41:14]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[vmiura, 2014-05-12 22:13:57]

The CQ bit was checked by vmiura@chromium.org

[commit-bot: I haz the power, 2014-05-12 22:15:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kkinnunen@nvidia.com/272953002/20001

[commit-bot: I haz the power, 2014-05-12 23:43:07]

Change committed as 269914