Remove the |max_threads| argument from CreateAndSetSimpleTaskScheduler().

base/task_scheduler/task_scheduler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TASK_SCHEDULER_TASK_SCHEDULER_H_
 #define BASE_TASK_SCHEDULER_TASK_SCHEDULER_H_
 
 #include <memory>
+#include <string>
 #include <vector>
 
 #include "base/base_export.h"
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/sequenced_task_runner.h"
 #include "base/single_thread_task_runner.h"
 #include "base/task_runner.h"
 #include "base/task_scheduler/task_traits.h"
 #include "base/time/time.h"
@@ skipping 81 matching lines @@
 
   // CreateAndSetSimpleTaskScheduler(), CreateAndSetDefaultTaskScheduler(), and
   // SetInstance() register a TaskScheduler to handle tasks posted through the
   // post_task.h API for this process. The registered TaskScheduler will only be
   // deleted when a new TaskScheduler is registered and is leaked on shutdown.
   // The methods must not be called when TaskRunners created by the previous
   // TaskScheduler are still alive. The methods are not thread-safe; proper
   // synchronization is required to use the post_task.h API after registering a
   // new TaskScheduler.
 
-  // Creates and sets a task scheduler with one worker pool that can have up to
-  // |max_threads| threads. CHECKs on failure. For tests, prefer
+  // Creates and sets a task scheduler using default params. |name| will be used
+  // to label threads and histograms. CHECKs on failure. For tests, prefer

[robliao, 2017/03/13 23:56:05]

Add guidance on choosing a name (e.g. it should identify your component).

[fdoray, 2017/03/14 15:08:22]

Done.

   // base::test::ScopedTaskScheduler (ensures isolation).
-  static void CreateAndSetSimpleTaskScheduler(int max_threads);
+  static void CreateAndSetSimpleTaskScheduler(const std::string& name);

[robliao, 2017/03/13 23:56:05]

Note this change in the CL description.

[fdoray, 2017/03/14 15:08:22]

Done.

 
   // Creates and sets a task scheduler with custom worker pools. CHECKs on
   // failure. |worker_pool_params_vector| describes the worker pools to create.
   // |worker_pool_index_for_traits_callback| returns the index in |worker_pools|
   // of the worker pool in which a task with given traits should run. For tests,
   // prefer base::test::ScopedTaskScheduler (ensures isolation).
   static void CreateAndSetDefaultTaskScheduler(
       const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector,
       const WorkerPoolIndexForTraitsCallback&
           worker_pool_index_for_traits_callback);
@@ skipping 27 matching lines @@
   // each process n/GetMaxConcurrentTasksWithTraitsDeprecated() items.
   //
   // TODO(fdoray): Remove this method. https://crbug.com/687264
   virtual int GetMaxConcurrentTasksWithTraitsDeprecated(
       const TaskTraits& traits) const = 0;
 };
 
 }  // namespace base
 
 #endif  // BASE_TASK_SCHEDULER_TASK_SCHEDULER_H_