Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2611)

Unified Diff: device/vr/android/gvr/gvr_delegate.h

Issue 2729523002: Re-land^2 WebVR compositor bypass via BrowserMain context + mailbox (Closed)
Patch Set: Comments only, add explanations from review thread. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/vr/android/gvr/gvr_delegate.h
diff --git a/device/vr/android/gvr/gvr_delegate.h b/device/vr/android/gvr/gvr_delegate.h
index ed31de3388bd346dabdc6b2aff14ca2fb5d7ac7a..8684f59c16ba3d023ada112f8e114fcce6b87835 100644
--- a/device/vr/android/gvr/gvr_delegate.h
+++ b/device/vr/android/gvr/gvr_delegate.h
@@ -17,10 +17,12 @@ constexpr gvr::Sizei kInvalidRenderTargetSize = {0, 0};
class DEVICE_VR_EXPORT GvrDelegate {
public:
virtual void SetWebVRSecureOrigin(bool secure_origin) = 0;
- virtual void SubmitWebVRFrame() = 0;
+ virtual void SubmitWebVRFrame(int16_t frame_index,
+ const gpu::MailboxHolder& mailbox) = 0;
virtual void UpdateWebVRTextureBounds(int16_t frame_index,
const gvr::Rectf& left_bounds,
- const gvr::Rectf& right_bounds) = 0;
+ const gvr::Rectf& right_bounds,
+ const gvr::Sizei& source_size) = 0;
virtual void OnVRVsyncProviderRequest(
mojom::VRVSyncProviderRequest request) = 0;
virtual void UpdateVSyncInterval(int64_t timebase_nanos,
@@ -44,6 +46,7 @@ class DEVICE_VR_EXPORT GvrDelegateProvider {
virtual void SetDeviceProvider(GvrDeviceProvider* device_provider) = 0;
virtual void ClearDeviceProvider() = 0;
virtual void RequestWebVRPresent(
+ mojom::VRSubmitFrameClientPtr submit_client,
const base::Callback<void(bool)>& callback) = 0;
virtual void ExitWebVRPresent() = 0;
virtual GvrDelegate* GetDelegate() = 0;

Powered by Google App Engine
This is Rietveld 408576698