Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: third_party/WebKit/public/blink_typemaps.gni

Issue 2729523002: Re-land^2 WebVR compositor bypass via BrowserMain context + mailbox (Closed)
Patch Set: Revert FrameView.cpp change, re-enable typemap workaround. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/blink_typemaps.gni
diff --git a/third_party/WebKit/public/blink_typemaps.gni b/third_party/WebKit/public/blink_typemaps.gni
index 0ae607116324125a95d1a42b21215630fc5e415e..0252d61bca3938d0f0a7aa4b7f3d8432a1d1dc90 100644
--- a/third_party/WebKit/public/blink_typemaps.gni
+++ b/third_party/WebKit/public/blink_typemaps.gni
@@ -11,5 +11,11 @@ typemaps = [
"//cc/ipc/surface_id.typemap",
"//cc/ipc/surface_info.typemap",
"//cc/ipc/surface_sequence.typemap",
+
+ # Including mailbox here causes link errors, collision between
+ # gpu/ipc/common/interfaces/mailbox_struct_traits.o vs
+ # gpu/ipc/common/interfaces_blink/mailbox_struct_traits.o
+ # Does this not work for struct_traits with a .cc implementation?
+ # "//gpu/ipc/common/mailbox.typemap",
"//gpu/ipc/common/sync_token.typemap",
]

Powered by Google App Engine
This is Rietveld 408576698