Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Side by Side Diff: tools/patch_sdk.py

Issue 2729503006: GN: change the way we specify dependencies for the patched_sdk target. (Closed)
Patch Set: Address review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/patch_sdk.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 2 # Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
3 # for details. All rights reserved. Use of this source code is governed by a 3 # for details. All rights reserved. Use of this source code is governed by a
4 # BSD-style license that can be found in the LICENSE file. 4 # BSD-style license that can be found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import os 7 import os
8 import subprocess 8 import subprocess
9 import sys 9 import sys
10 import utils 10 import utils
(...skipping 30 matching lines...) Expand all
41 if utils.CheckedInSdkCheckExecutable(): 41 if utils.CheckedInSdkCheckExecutable():
42 options.dart_executable = utils.CheckedInSdkExecutable() 42 options.dart_executable = utils.CheckedInSdkExecutable()
43 elif options.dart_executable is not None: 43 elif options.dart_executable is not None:
44 if not options.quiet: 44 if not options.quiet:
45 DisplayBootstrapWarning() 45 DisplayBootstrapWarning()
46 options.dart_executable = os.path.abspath(options.dart_executable) 46 options.dart_executable = os.path.abspath(options.dart_executable)
47 else: 47 else:
48 print >> sys.stderr, 'ERROR: cannot locate dart executable' 48 print >> sys.stderr, 'ERROR: cannot locate dart executable'
49 return -1 49 return -1
50 dart_file = os.path.join(os.path.dirname(__file__), 'patch_sdk.dart') 50 dart_file = os.path.join(os.path.dirname(__file__), 'patch_sdk.dart')
51 subprocess.check_call([options.dart_executable, dart_file] + args) 51 subprocess.check_call(
52 [options.dart_executable, '--checked', dart_file] + args)
52 return 0 53 return 0
53 54
54 if __name__ == '__main__': 55 if __name__ == '__main__':
55 sys.exit(main()) 56 sys.exit(main())
OLDNEW
« no previous file with comments | « tools/patch_sdk.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698