PlzNavigate: add support for BLOCK_REQUEST during redirects

PlzNavigate: add support for BLOCK_REQUEST during redirects

This CL adds support for blocking requests in NavigationRequest during
redirects. It also fixes an issue in NavigationHandle, without
PlzNavigate activated, where the NavigationHandle would not be properly
recognized at error page commit if the navigation was blocked by a
NavigationThrottle during a redirect.

This is based on arthursonzogni@ CLs
https://codereview.chromium.org/2712123002/ and
https://codereview.chromium.org/2698623006 that I'm trying to land while
he's OOO.

BUG=685074, 695421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

[clamy, 2017-03-01 17:45:53]

Description was changed from

==========
PlzNavigate: add support for BLOCK_REQUEST during redirects

This CL adds support for blocking requests in NavigationRequest during
redirects. It also fixes an issue in NavigationHandle, without
PlzNavigate activated, where the NavigationHandle would not be properly
recognized at error page commit if the navigation was blocked by a
NavigationThrottle during a redirect.

This is based on arthursonzogni@ CLs
https://codereview.chromium.org/2712123002/ and
https://codereview.chromium.org/2698623006 that I'm trying to land while
he's OOO.

BUG=685074,695421
==========

to

==========
PlzNavigate: add support for BLOCK_REQUEST during redirects

This CL adds support for blocking requests in NavigationRequest during
redirects. It also fixes an issue in NavigationHandle, without
PlzNavigate activated, where the NavigationHandle would not be properly
recognized at error page commit if the navigation was blocked by a
NavigationThrottle during a redirect.

This is based on arthursonzogni@ CLs
https://codereview.chromium.org/2712123002/ and
https://codereview.chromium.org/2698623006 that I'm trying to land while
he's OOO.

BUG=685074,695421
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[clamy, 2017-03-01 17:52:51]

clamy@chromium.org changed reviewers:
+ creis@chromium.org, nasko@chromium.org

[clamy, 2017-03-01 17:52:52]

@nasko, creis: PTAL.

This is a merge of two of Arthur CLs that are needed for the CSP work in
PlzNavigate. I'm trying to get them to land as he's OOO.

I've modified the approach to deal with the error page and NavigationHandle
issue. The only problem with what I have here, is that I suspect that if
something that is not a NavigationThrottle cancels the navigation during the
redirect *after* the NavigationThrottle got to execute but *before* we send the
redirect IPC to the renderer we would still have a problem.

@creis: the solution you asked for in the review (ie send the Redirect IPC) is
really complicated, given how the chain of ResourceHandlers work. Basically, we
need to call cancel before the leaf ResourceHandler is even aware of the
redirect, and this results in a call of OnResponseCompleted. And
ResourceHandlers do not expect to be called after the response has supposedly
completed.

[nasko, 2017-03-01 18:12:43]

Just a couple of nits. I'll leave the approval to creis@, as he had concerns
with the previous version of the CL.

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_handle_impl.cc:580: if
(!IsSelfReferentialURL()) {
nit: It is easier to read the positive statement, so I'd suggest switching it
around if there is a follow up patchset.

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_handle_impl_browsertest.cc (right):

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_handle_impl_browsertest.cc:1093: const
std::vector<GURL>& GetStartedNavigationURLS() {
nit: hacker_case

[clamy, 2017-03-02 12:43:04]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[clamy, 2017-03-02 12:43:17]

Thanks!

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_handle_impl.cc (right):

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_handle_impl.cc:580: if
(!IsSelfReferentialURL()) {
On 2017/03/01 18:12:43, nasko (slow) wrote:
> nit: It is easier to read the positive statement, so I'd suggest switching it
> around if there is a follow up patchset.

Done.

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
File content/browser/frame_host/navigation_handle_impl_browsertest.cc (right):

https://codereview.chromium.org/2729433003/diff/1/content/browser/frame_host/...
content/browser/frame_host/navigation_handle_impl_browsertest.cc:1093: const
std::vector<GURL>& GetStartedNavigationURLS() {
On 2017/03/01 18:12:43, nasko (slow) wrote:
> nit: hacker_case

Done.

[commit-bot: I haz the power, 2017-03-02 12:43:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 13:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 13:51:48]

Dry run: This issue passed the CQ dry run.