Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2729233002:
Ignore the "Edit" links in wiki pages (Closed)
DescriptionIgnore the "Edit" links in wiki pages
Treat the "Edit" links in mediawiki pages as if they were not there.
Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages
Score changes (as of @150267738):
https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.html
1 entry changed: Precision 0.990 → 0.992
https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile-mhtml.html
2 entries changed:
Mobile version of wikipedia (expanded), and tablet version:
Precision 0.998 → 1.000
Recall 0.667 → 0.683
7/~1000 in distillable-desktop-mhtml has positive changes.
No changes on:
cjk-golden-data
multi-page-golden-data
page-links-golden-data
reader-images-golden-data
BUG=647667
R=mdjones@chromium.org
Committed: 9c2021c7bac101af30dfc5ebfea003f1f80de05e
Patch Set 1 #Patch Set 2 : fix redlink and desktop #
Total comments: 2
Patch Set 3 : add comments #
Messages
Total messages: 14 (9 generated)
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. All links with "action=edit" in href would be matched. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages BUG=647667 ==========
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. All links with "action=edit" in href would be matched. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes: https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.995 → 0.998 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data top-mobile-mhtml BUG=647667 ==========
wychen@chromium.org changed reviewers: + mdjones@chromium.org
PTAL
https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/disti... File java/org/chromium/distiller/webdocument/DomConverter.java (right): https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/disti... java/org/chromium/distiller/webdocument/DomConverter.java:159: String editPattern = "action=edit§ion="; Is "action=edit" used for more than just editing? How necessary is the "§ion="?
https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/disti... File java/org/chromium/distiller/webdocument/DomConverter.java (right): https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/disti... java/org/chromium/distiller/webdocument/DomConverter.java:159: String editPattern = "action=edit§ion="; On 2017/03/14 15:59:50, mdjones wrote: > Is "action=edit" used for more than just editing? How necessary is the > "§ion="? For "redlinks" (links to entries yet to be created), the href pattern is "action=edit&redlink=". I've added a comment. I didn't know this either until running eval.
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes: https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.995 → 0.998 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data top-mobile-mhtml BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes: https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.995 → 0.998 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ==========
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes: https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.995 → 0.998 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150257299): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ==========
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150257299): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150257299): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: Mobile version of wikipedia (expanded): Precision 0.998 → 1.000 Recall 0.667 → 0.683 Tablet version of wikipedia: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ==========
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150257299): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: Mobile version of wikipedia (expanded): Precision 0.998 → 1.000 Recall 0.667 → 0.683 Tablet version of wikipedia: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150257299): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: Mobile version of wikipedia (expanded), and tablet version: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ==========
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150257299): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: Mobile version of wikipedia (expanded), and tablet version: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150267738): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: Mobile version of wikipedia (expanded), and tablet version: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ==========
lgtm
Description was changed from ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150267738): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: Mobile version of wikipedia (expanded), and tablet version: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 ========== to ========== Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150267738): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.... 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile... 2 entries changed: Mobile version of wikipedia (expanded), and tablet version: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 R=mdjones@chromium.org Committed: 9c2021c7bac101af30dfc5ebfea003f1f80de05e ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 9c2021c7bac101af30dfc5ebfea003f1f80de05e (presubmit successful). |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
