Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 2729233002: Ignore the "Edit" links in wiki pages (Closed)

Created:
3 years, 9 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
mdjones
CC:
noyau (Ping after 24h), Olivier, lody, gambard
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ignore the "Edit" links in wiki pages Treat the "Edit" links in mediawiki pages as if they were not there. Ref: https://www.mediawiki.org/wiki/API:Edit#Editing_pages Score changes (as of @150267738): https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/knowledge.html 1 entry changed: Precision 0.990 → 0.992 https://x20web.corp.google.com/~wychen/domdistillerscore/wiki-edit/top-mobile-mhtml.html 2 entries changed: Mobile version of wikipedia (expanded), and tablet version: Precision 0.998 → 1.000 Recall 0.667 → 0.683 7/~1000 in distillable-desktop-mhtml has positive changes. No changes on: cjk-golden-data multi-page-golden-data page-links-golden-data reader-images-golden-data BUG=647667 R=mdjones@chromium.org Committed: 9c2021c7bac101af30dfc5ebfea003f1f80de05e

Patch Set 1 #

Patch Set 2 : fix redlink and desktop #

Total comments: 2

Patch Set 3 : add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M java/org/chromium/distiller/webdocument/DomConverter.java View 1 2 2 chunks +19 lines, -1 line 0 comments Download
M javatests/org/chromium/distiller/webdocument/DomConverterTest.java View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
wychen
PTAL
3 years, 9 months ago (2017-03-14 00:47:09 UTC) #4
mdjones
https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/distiller/webdocument/DomConverter.java File java/org/chromium/distiller/webdocument/DomConverter.java (right): https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/distiller/webdocument/DomConverter.java#newcode159 java/org/chromium/distiller/webdocument/DomConverter.java:159: String editPattern = "action=edit&section="; Is "action=edit" used for more ...
3 years, 9 months ago (2017-03-14 15:59:50 UTC) #5
wychen
https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/distiller/webdocument/DomConverter.java File java/org/chromium/distiller/webdocument/DomConverter.java (right): https://codereview.chromium.org/2729233002/diff/20001/java/org/chromium/distiller/webdocument/DomConverter.java#newcode159 java/org/chromium/distiller/webdocument/DomConverter.java:159: String editPattern = "action=edit&section="; On 2017/03/14 15:59:50, mdjones wrote: ...
3 years, 9 months ago (2017-03-14 21:48:54 UTC) #6
mdjones
lgtm
3 years, 9 months ago (2017-03-22 22:20:28 UTC) #12
wychen
3 years, 8 months ago (2017-04-11 00:42:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
9c2021c7bac101af30dfc5ebfea003f1f80de05e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698