Issue 272923002: Fix experimental app list contents switcher being positioned incorrectly on profile switch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 272923002: Fix experimental app list contents switcher being positioned incorrectly on profile switch. (Closed)

Created:
6 years, 7 months ago by calamity

Modified:
6 years, 7 months ago

Reviewers:
tapted

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@ares_start_page

Visibility:
Public.

More Reviews

Description

Fix experimental app list contents switcher being positioned incorrectly on profile switch. This CL fixes an issue with the experimental app launcher's buttons being laid out above the app grid due to the contents view being re-added on profile switch. This has been fixed by ensuring the contents view is always added to the same position. BUG=371695 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269550

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ui/app_list/views/app_list_main_view.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/272923002/1

6 years, 7 months ago (2014-05-09 07:00:00 UTC) #4

Message was sent while issue was closed.

Change committed as 269550

Expand Messages | Collapse Messages