chrome/browser/ui/views/omnibox/omnibox_view_views.h - Issue 2729133005: Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 2729133005: Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box' (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

index c344e4a31099c53bdb6128999e3305d913d8ce33..3d1f90c0a8661b3ad05c6ff6c8b53c08c12cf194 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

@@ -174,7 +174,7 @@ class OmniboxViewViews

base::string16 GetSelectionClipboardText() const override;

void DoInsertChar(base::char16 ch) override;

bool IsTextEditCommandEnabled(ui::TextEditCommand command) const override;

- void ExecuteTextEditCommand(ui::TextEditCommand command) override;

+ bool ExecuteTextEditCommandImpl(ui::TextEditCommand command) override;

// chromeos::input_method::InputMethodManager::CandidateWindowObserver:

#if defined(OS_CHROMEOS)