Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include <set>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 803 matching lines @@
     case ui::TextEditCommand::MOVE_UP:
     case ui::TextEditCommand::MOVE_DOWN:
       return !read_only();
     case ui::TextEditCommand::PASTE:
       return !read_only() && !GetClipboardText().empty();
     default:
       return Textfield::IsTextEditCommandEnabled(command);
   }
 }
 
-void OmniboxViewViews::ExecuteTextEditCommand(ui::TextEditCommand command) {
-  // In the base class, touch text selection is deactivated when a command is
-  // executed. Since we are not always calling the base class implementation
-  // here, we need to deactivate touch text selection here, too.
-  DestroyTouchSelection();
-
-  if (!IsTextEditCommandEnabled(command))
-    return;
-
+bool OmniboxViewViews::ExecuteTextEditCommandImpl(ui::TextEditCommand command) {
   switch (command) {
     case ui::TextEditCommand::MOVE_UP:
       model()->OnUpOrDownKeyPressed(-1);
+      return false;

[sadrul, 2017/03/09 01:47:38]

I feel like this should be true? (also, below for MOVE_DOWN)

[yiyix, 2017/03/09 02:45:33]

Only OnPaste calls OnAfterPossibleChange, that's why I set the return value to
true to OnPaste only. The MOVE_UP and MOVE_DOWN are used to choose a word in a
popup window for composition text. The cursor visibility is not changed by
moving up or moving down in he popup window.

       break;

[sadrul, 2017/03/09 01:47:38]

You should remove the break; (here and below)

[yiyix, 2017/03/09 02:45:33]

No break needed after return. Right. I will watch out for that.

     case ui::TextEditCommand::MOVE_DOWN:
       model()->OnUpOrDownKeyPressed(1);
+      return false;
       break;
     case ui::TextEditCommand::PASTE:
       OnPaste();
+      return true;
       break;
     default:
-      Textfield::ExecuteTextEditCommand(command);
+      return Textfield::ExecuteTextEditCommandImpl(command);
       break;
   }
 }
 
 #if defined(OS_CHROMEOS)
 void OmniboxViewViews::CandidateWindowOpened(
       chromeos::input_method::InputMethodManager* manager) {
   ime_candidate_window_open_ = true;
 }
 
@@ skipping 194 matching lines @@
       paste_position + 1, IDS_PASTE_AND_GO, IDS_PASTE_AND_GO);
 
   menu_contents->AddSeparator(ui::NORMAL_SEPARATOR);
 
   // Minor note: We use IDC_ for command id here while the underlying textfield
   // is using IDS_ for all its command ids. This is because views cannot depend
   // on IDC_ for now.
   menu_contents->AddItemWithStringId(IDC_EDIT_SEARCH_ENGINES,
       IDS_EDIT_SEARCH_ENGINES);
 }