Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 165 matching lines @@
   views::Textfield* omnibox_textfield() { return omnibox_view(); }
   ui::TextEditCommand scheduled_text_edit_command() const {
     return test_api_->scheduled_text_edit_command();
   }
 
   // Sets |new_text| as the omnibox text, and emphasizes it appropriately.  If
   // |accept_input| is true, pretends that the user has accepted this input
   // (i.e. it's been navigated to).
   void SetAndEmphasizeText(const std::string& new_text, bool accept_input);
 
+  bool IsCursorEnabled() const {
+    return test_api_->GetRenderText()->cursor_enabled();
+  }
+
  private:
   // testing::Test:
   void SetUp() override;
   void TearDown() override;
 
   content::TestBrowserThreadBundle thread_bundle_;
   TestingProfile profile_;
   TemplateURLServiceFactoryTestUtil util_;
   CommandUpdater command_updater_;
   TestToolbarModel toolbar_model_;
@@ skipping 63 matching lines @@
   omnibox_textfield()->InsertChar(char_event);
   omnibox_view()->CheckUpdatePopupCallInfo(2, base::ASCIIToUTF16("ab"),
                                            Range(2));
 
   ui::KeyEvent pressed(ui::ET_KEY_PRESSED, ui::VKEY_BACK, 0);
   omnibox_textfield()->OnKeyEvent(&pressed);
   omnibox_view()->CheckUpdatePopupCallInfo(3, base::ASCIIToUTF16("a"),
                                            Range(1));
 }
 
+// Checks that if the text cursor is set to enabled after inserting a single

[msw, 2017/03/10 21:04:30]

nit: no 'if'; cite the bug (and relation to the fake search bar)?

[yiyix, 2017/03/13 04:02:16]

Done.

+// char to the omnibox.
+TEST_F(OmniboxViewViewsTest, EditTextfield) {
+  omnibox_textfield()->SetCursorEnabled(false);
+  ui::KeyEvent char_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::DomCode::US_A, 0,
+                          ui::DomKey::FromCharacter('a'),
+                          ui::EventTimeForNow());
+  omnibox_textfield()->InsertChar(char_event);

[msw, 2017/03/10 21:04:30]

Should this also have a test for pasting, like the old TextfieldTest,
CursorVisibilityChangeAfterPaste?

[yiyix, 2017/03/13 04:02:16]

With the old approach, paste and insert char uses different code path. Since
they use the same code path now, I only added this test case.

+  EXPECT_TRUE(IsCursorEnabled());
+}
+
 // Test that the scheduled text edit command is cleared when Textfield receives
 // a key press event. This ensures that the scheduled text edit command property
 // is always in the correct state. Test for http://crbug.com/613948.
 TEST_F(OmniboxViewViewsTest, ScheduledTextEditCommand) {
   omnibox_textfield()->SetTextEditCommandForNextKeyEvent(
       ui::TextEditCommand::MOVE_UP);
   EXPECT_EQ(ui::TextEditCommand::MOVE_UP, scheduled_text_edit_command());
 
   ui::KeyEvent up_pressed(ui::ET_KEY_PRESSED, ui::VKEY_UP, 0);
   omnibox_textfield()->OnKeyEvent(&up_pressed);
@@ skipping 39 matching lines @@
       EXPECT_EQ(TestingOmniboxView::to_base_text_emphasis(
                     test_case.expected_base_text_emphasized),
                 omnibox_view()->base_text_emphasis());
       EXPECT_EQ(test_case.expected_emphasis_range,
                 omnibox_view()->emphasis_range());
       EXPECT_EQ(test_case.expected_scheme_range,
                 omnibox_view()->scheme_range());
     }
   }
 }