Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 437 matching lines @@
   GetRenderText()->set_selection_background_focused_color(
       GetSelectionBackgroundColor());
   SchedulePaint();
 }
 
 bool Textfield::GetCursorEnabled() const {
   return GetRenderText()->cursor_enabled();
 }
 
 void Textfield::SetCursorEnabled(bool enabled) {
+  if (GetRenderText()->cursor_enabled() == enabled) {

[msw, 2017/03/09 21:05:45]

nit: curlies not needed

[yiyix, 2017/03/10 20:19:29]

Done.

+    return;
+  }
   GetRenderText()->SetCursorEnabled(enabled);
+  UpdateCursorView();
+  ShowCursor();
 }
 
 const gfx::FontList& Textfield::GetFontList() const {
   return GetRenderText()->font_list();
 }
 
 void Textfield::SetFontList(const gfx::FontList& font_list) {
   GetRenderText()->SetFontList(font_list);
   OnCaretBoundsChanged();
   PreferredSizeChanged();
@@ skipping 1435 matching lines @@
 }
 
 void Textfield::UpdateAfterChange(bool text_changed, bool cursor_changed) {
   if (text_changed) {
     if (controller_)
       controller_->ContentsChanged(this, text());
     NotifyAccessibilityEvent(ui::AX_EVENT_TEXT_CHANGED, true);
   }
   if (cursor_changed) {
     UpdateCursorView();
-    cursor_view_.SetVisible(ShouldShowCursor());
-    if (ShouldBlinkCursor())
-      StartBlinkingCursor();
-    else
-      StopBlinkingCursor();
+    ShowCursor();
     NotifyAccessibilityEvent(ui::AX_EVENT_TEXT_SELECTION_CHANGED, true);
   }
   if (text_changed || cursor_changed) {
     OnCaretBoundsChanged();
     SchedulePaint();
   }
 }
 
+void Textfield::ShowCursor() {

[msw, 2017/03/09 21:05:45]

Can we inline this into UpdateCursorView()? Otherwise consider renaming this
"UpdateCursorVisibility" or similar; the name "ShowCursor" doesn't capture the
possibility that this may actually hide the cursor and stop its blinking.

[yiyix, 2017/03/10 20:19:29]

I don't think inline this into UpdateCursorView is a good idea. Since the
function OnCursorBlinkTimerFired() calls UpdateCursorView and change the
visibility, the updateCursorView should not call blink.

I will update the name.

[msw, 2017/03/10 21:04:29]

Acknowledged.

+  cursor_view_.SetVisible(ShouldShowCursor());
+  if (ShouldBlinkCursor())
+    StartBlinkingCursor();
+  else
+    StopBlinkingCursor();
+}
+
 void Textfield::UpdateCursorView() {
   gfx::Rect location(GetRenderText()->GetUpdatedCursorBounds());
   location.set_x(GetMirroredXForRect(location));
   cursor_view_.SetBoundsRect(location);
 }
 
 void Textfield::PaintTextAndCursor(gfx::Canvas* canvas) {
   TRACE_EVENT0("views", "Textfield::PaintTextAndCursor");
   canvas->Save();
 
@@ skipping 149 matching lines @@
   cursor_blink_timer_.Stop();
 }
 
 void Textfield::OnCursorBlinkTimerFired() {
   DCHECK(ShouldBlinkCursor());
   cursor_view_.SetVisible(!cursor_view_.visible());
   UpdateCursorView();
 }
 
 }  // namespace views