Fix: Cursor missing in omnibox after entering a alphabet in NTP 'Search box'

ui/views/controls/textfield/textfield.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <string>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
@@ skipping 865 matching lines @@
     // Adjust the drop destination if it is on or after the current selection.
     size_t pos = drop_destination_model.caret_pos();
     pos -= render_text->selection().Intersect(gfx::Range(0, pos)).length();
     model_->DeleteSelectionAndInsertTextAt(new_text, pos);
   } else {
     model_->MoveCursorTo(drop_destination_model);
     // Drop always inserts text even if the textfield is not in insert mode.
     model_->InsertText(new_text);
   }
   skip_input_method_cancel_composition_ = false;
+  OnAfterUserAction();
   UpdateAfterChange(true, true);
-  OnAfterUserAction();
   return move ? ui::DragDropTypes::DRAG_MOVE : ui::DragDropTypes::DRAG_COPY;
 }
 
 void Textfield::OnDragDone() {
   initiating_drag_ = false;
   drop_cursor_visible_ = false;
 }
 
 void Textfield::GetAccessibleNodeData(ui::AXNodeData* node_data) {
   node_data->role = ui::AX_ROLE_TEXT_FIELD;
@@ skipping 359 matching lines @@
 
 void Textfield::SetCompositionText(const ui::CompositionText& composition) {
   if (GetTextInputType() == ui::TEXT_INPUT_TYPE_NONE)
     return;
 
   OnBeforeUserAction();
   skip_input_method_cancel_composition_ = true;
   model_->SetCompositionText(composition);
   skip_input_method_cancel_composition_ = false;
   UpdateAfterChange(true, true);
   OnAfterUserAction();

[sadrul, 2017/03/04 04:05:17]

There are a few other places where OnAfterUserAction() is called after the call
to UpdateAfterChange() (e.g. here, ConfirmCompositionText(),
ClearCompositionText(), InsertText(), ExecuteTextEditCommand()). Should these be
reversed as well?

 }
 
 void Textfield::ConfirmCompositionText() {
   if (!model_->HasCompositionText())
     return;
 
   OnBeforeUserAction();
   skip_input_method_cancel_composition_ = true;
   model_->ConfirmCompositionText();
   skip_input_method_cancel_composition_ = false;
@@ skipping 298 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // Textfield, protected:
 
 void Textfield::DoInsertChar(base::char16 ch) {
   OnBeforeUserAction();
   skip_input_method_cancel_composition_ = true;
   model_->InsertChar(ch);
   skip_input_method_cancel_composition_ = false;
 
+  OnAfterUserAction();
   UpdateAfterChange(true, true);
-  OnAfterUserAction();
 }
 
 gfx::RenderText* Textfield::GetRenderText() const {
   return model_->render_text();
 }
 
 gfx::Point Textfield::GetLastClickLocation() const {
   return selection_controller_.last_click_location();
 }
 
@@ skipping 488 matching lines @@
   cursor_blink_timer_.Stop();
 }
 
 void Textfield::OnCursorBlinkTimerFired() {
   DCHECK(ShouldBlinkCursor());
   cursor_view_.SetVisible(!cursor_view_.visible());
   UpdateCursorView();
 }
 
 }  // namespace views