Fix crash during sync load of the signin profile

chrome/browser/policy/profile_policy_connector_factory.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/profile_policy_connector_factory.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"

[bartfab (slow), 2017/03/03 17:31:28]

Nit: No longer used.

[emaxx, 2017/03/03 17:42:09]

Done.

 #include "chrome/browser/policy/profile_policy_connector.h"
 #include "chrome/browser/policy/schema_registry_service.h"
 #include "chrome/browser/policy/schema_registry_service_factory.h"
 #include "chrome/browser/profiles/incognito_helpers.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/policy/core/common/policy_service.h"
 #include "components/policy/core/common/policy_service_impl.h"
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/policy/active_directory_policy_manager.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"

[bartfab (slow), 2017/03/03 17:31:28]

Nit: No longer used.

[emaxx, 2017/03/03 17:42:09]

Done.

 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"

[bartfab (slow), 2017/03/03 17:31:28]

Nit: No longer used.

[emaxx, 2017/03/03 17:42:09]

Done.

 #include "chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h"
 #include "chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "components/user_manager/user.h"
 #else  // Non-ChromeOS.
 #include "chrome/browser/policy/cloud/user_cloud_policy_manager_factory.h"
 #include "components/policy/core/common/cloud/user_cloud_policy_manager.h"
 #endif
 
 namespace policy {
@@ skipping 67 matching lines @@
 
   const user_manager::User* user = nullptr;
   SchemaRegistry* schema_registry =
       SchemaRegistryServiceFactory::GetForContext(context)->registry();
 
   ConfigurationPolicyProvider* policy_provider = nullptr;
   const CloudPolicyStore* policy_store = nullptr;
 
 #if defined(OS_CHROMEOS)
   Profile* const profile = Profile::FromBrowserContext(context);
-  if (chromeos::ProfileHelper::IsSigninProfile(profile)) {
-    policy::DeviceCloudPolicyManagerChromeOS* device_cloud_policy_manager =
-        g_browser_process->platform_part()
-            ->browser_policy_connector_chromeos()
-            ->GetDeviceCloudPolicyManager();
-    // TODO(tnagel): Do we need to do something for Active Directory management?
-    if (device_cloud_policy_manager) {
-      device_cloud_policy_manager->SetSigninProfileSchemaRegistry(
-          schema_registry);
-    }
-  } else {
+  if (!chromeos::ProfileHelper::IsSigninProfile(profile)) {
     user = chromeos::ProfileHelper::Get()->GetUserByProfile(profile);
     CHECK(user);
   }
 
   CloudPolicyManager* user_cloud_policy_manager =
       UserPolicyManagerFactoryChromeOS::GetCloudPolicyManagerForProfile(
           profile);
   ActiveDirectoryPolicyManager* active_directory_manager =
       UserPolicyManagerFactoryChromeOS::
           GetActiveDirectoryPolicyManagerForProfile(profile);
@@ skipping 53 matching lines @@
 
 bool ProfilePolicyConnectorFactory::HasTestingFactory(
     content::BrowserContext* context) {
   return false;
 }
 
 void ProfilePolicyConnectorFactory::CreateServiceNow(
     content::BrowserContext* context) {}
 
 }  // namespace policy