Chromium Code Reviews| Index: src/compiler/node-matchers.h |
| diff --git a/src/compiler/node-matchers.h b/src/compiler/node-matchers.h |
| index d2bdb8bff5bdbe3ede04eefbf5fb667c0e5892f9..550317d2484836661f1027105c365a427f080c18 100644 |
| --- a/src/compiler/node-matchers.h |
| +++ b/src/compiler/node-matchers.h |
| @@ -252,6 +252,9 @@ struct BinopMatcher : public NodeMatcher { |
| protected: |
| void SwapInputs() { |
| std::swap(left_, right_); |
| + // TODO(tebbi): This modification should notify the reducers using |
|
Michael Starzinger
2017/03/02 16:38:35
It might make sense to also file a bug on the issu
|
| + // BinopMatcher. Alternatively, all reducers (especially value numbering) |
| + // could ignore the ordering for commutative binops. |
| node()->ReplaceInput(0, left().node()); |
| node()->ReplaceInput(1, right().node()); |
| } |