Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: src/compiler/node-matchers.h

Issue 2728983002: [wasm] change reducer order in WASM pipeline to make build predictable again (Closed)
Patch Set: added todo Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/node-matchers.h
diff --git a/src/compiler/node-matchers.h b/src/compiler/node-matchers.h
index d2bdb8bff5bdbe3ede04eefbf5fb667c0e5892f9..550317d2484836661f1027105c365a427f080c18 100644
--- a/src/compiler/node-matchers.h
+++ b/src/compiler/node-matchers.h
@@ -252,6 +252,9 @@ struct BinopMatcher : public NodeMatcher {
protected:
void SwapInputs() {
std::swap(left_, right_);
+ // TODO(tebbi): This modification should notify the reducers using
Michael Starzinger 2017/03/02 16:38:35 It might make sense to also file a bug on the issu
+ // BinopMatcher. Alternatively, all reducers (especially value numbering)
+ // could ignore the ordering for commutative binops.
node()->ReplaceInput(0, left().node());
node()->ReplaceInput(1, right().node());
}
« src/builtins/builtins.h ('K') | « src/builtins/builtins.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698