Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html

Issue 2728963004: Remove non-standard DeviceOrientation Event initializers. (Closed)
Patch Set: Rebased. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html
diff --git a/third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html b/third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html
index add4a1bcdebf34bada9f0946395cb0b477e57e38..5640194116845b2ac444977830926643467d14be 100644
--- a/third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html
+++ b/third_party/WebKit/LayoutTests/device_orientation/orientation/optional-event-properties.html
@@ -13,43 +13,43 @@ shouldBeTrue("event.beta == null");
shouldBeTrue("event.gamma == null");
shouldBeFalse("event.absolute");
-evalAndLog("event.initDeviceOrientationEvent('', false, false, 0, 1, 2, false)");
+evalAndLog("event = new DeviceOrientationEvent('', {alpha: 0, beta: 1, gamma: 2, absolute: false})");
shouldBeTrue("event.alpha == 0");
shouldBeTrue("event.beta == 1");
shouldBeTrue("event.gamma == 2");
shouldBeFalse("event.absolute");
-evalAndLog("event.initDeviceOrientationEvent('', false, false, 0, 1, 2, true)");
+evalAndLog("event = new DeviceOrientationEvent('', {alpha: 0, beta: 1, gamma: 2, absolute: true})");
shouldBeTrue("event.alpha == 0");
shouldBeTrue("event.beta == 1");
shouldBeTrue("event.gamma == 2");
shouldBeTrue("event.absolute");
-evalAndLog("event.initDeviceOrientationEvent()");
+evalAndLog("event = new DeviceOrientationEvent('')");
shouldBeTrue("event.alpha == null");
shouldBeTrue("event.beta == null");
shouldBeTrue("event.gamma == null");
shouldBeFalse("event.absolute");
-evalAndLog("event.initDeviceOrientationEvent('', false, false, [], [], [], [])");
+evalAndLog("event = new DeviceOrientationEvent('', {alpha: [], beta: [], gamma: [], absolute: []})");
shouldBeTrue("event.alpha == 0");
shouldBeTrue("event.beta == 0");
shouldBeTrue("event.gamma == 0");
shouldBeTrue("event.absolute");
-evalAndLog("event.initDeviceOrientationEvent('', false, false, undefined, undefined, undefined, undefined)");
+evalAndLog("event = new DeviceOrientationEvent('', {alpha: undefined, beta: undefined, gamma: undefined, absolute: undefined})");
shouldBeTrue("event.alpha == null");
shouldBeTrue("event.beta == null");
shouldBeTrue("event.gamma == null");
shouldBeFalse("event.absolute");
-evalAndLog("event.initDeviceOrientationEvent('', false, false, '', '', '', '')");
+evalAndLog("event = new DeviceOrientationEvent('', {alpha: '', beta: '', gamma: '', absolute: ''})");
shouldBeTrue("event.alpha == 0");
shouldBeTrue("event.beta == 0");
shouldBeTrue("event.gamma == 0");
shouldBeFalse("event.absolute");
-evalAndLog("event.initDeviceOrientationEvent('', false, false, null, null, null, null)");
+evalAndLog("event = new DeviceOrientationEvent('', {alpha: null, beta: null, gamma: null, absolute: null})");
shouldBeTrue("event.alpha == null");
shouldBeTrue("event.beta == null");
shouldBeTrue("event.gamma == null");

Powered by Google App Engine
This is Rietveld 408576698