net/cert/internal/parse_ocsp.cc - Issue 2728953003: Add support for MD2, MD4, and MD5 to SignatureAlgorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/parse_ocsp.cc

Issue 2728953003: Add support for MD2, MD4, and MD5 to SignatureAlgorithm. (Closed)

Patch Set: make verify_certificate_chain_unittests pass Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/internal/parse_ocsp.cc

diff --git a/net/cert/internal/parse_ocsp.cc b/net/cert/internal/parse_ocsp.cc

index 0e13fc3d09a0cdd1d438c6e1132267e1c23ac66e..a44290f25e4e95d1cc2ae61341dbff85a4fb9d8c 100644

--- a/net/cert/internal/parse_ocsp.cc

+++ b/net/cert/internal/parse_ocsp.cc

@@ -458,6 +458,11 @@ bool CheckCertID(const der::Input& id_tlv,

HashValueTag type = HASH_VALUE_SHA1;

switch (id.hash_algorithm) {

+ case DigestAlgorithm::Md2:

+ case DigestAlgorithm::Md4:

+ case DigestAlgorithm::Md5:

+ // Unsupported.

+ return false;

case DigestAlgorithm::Sha1:

type = HASH_VALUE_SHA1;

break;