Chromium Code Reviews| Index: remoting/android/BUILD.gn |
| diff --git a/remoting/android/BUILD.gn b/remoting/android/BUILD.gn |
| index 1be3c3e9940cc3d73c1f5a45a2a14e8ffd28b610..3949b4baea505d070bc14f3221a117c09b980d04 100644 |
| --- a/remoting/android/BUILD.gn |
| +++ b/remoting/android/BUILD.gn |
| @@ -64,21 +64,50 @@ shared_library("remoting_client_jni") { |
| assert_no_deps = [ "//third_party/ffmpeg:*" ] |
| } |
| +action("credits") { |
|
Lambros
2017/03/02 20:33:00
If it helps reviewing, this section is based off o
|
| + credits_html_file = "$target_gen_dir/credits.html" |
| + script = "//tools/licenses.py" |
| + depfile = "$target_gen_dir/$target_name.d" |
| + credits_template = "//remoting/credits/credits.tmpl" |
| + credits_entry_template = "//remoting/credits/credits_entry.tmpl" |
| + inputs = [ |
| + credits_template, |
| + credits_entry_template, |
| + ] |
| + outputs = [ |
| + credits_html_file, |
| + ] |
| + args = [ |
| + "credits", |
| + rebase_path(credits_html_file, root_build_dir), |
| + "--file-template", |
| + rebase_path(credits_template, root_build_dir), |
| + "--entry-template", |
| + rebase_path(credits_entry_template, root_build_dir), |
| + "--depfile", |
| + rebase_path(depfile, root_build_dir), |
| + "--gn-target", |
| + "//remoting/android:remoting_apk", |
| + "--gn-out-dir", |
| + rebase_path(root_build_dir), |
| + ] |
| +} |
| + |
| _raw_resources_base_dir = "$target_gen_dir/remoting_android_raw_resources/res" |
| copy("remoting_android_raw_resources") { |
| - _credits_html = get_label_info("//remoting/webapp:credits", |
| + _credits_html = get_label_info("//remoting/android:credits", |
| "target_gen_dir") + "/credits.html" |
| sources = [ |
| - "//remoting/webapp/base/html/credits_css.css", |
| - "//remoting/webapp/base/html/main.css", |
| - "//remoting/webapp/base/js/credits_js.js", |
| + "//remoting/credits/credits_css.css", |
| + "//remoting/credits/credits_js.js", |
| + "//remoting/credits/main.css", |
|
Jamie
2017/03/02 18:37:01
Is it worth splitting the CSS into two files? IIRC
Lambros
2017/03/03 01:53:16
Removed main.css and moved some styles into credit
|
| _credits_html, |
| ] |
| outputs = [ |
| "$_raw_resources_base_dir/raw/{{source_file_part}}", |
| ] |
| deps = [ |
| - "//remoting/webapp:credits", |
| + ":credits", |
| ] |
| } |