components/favicon/core/favicon_driver_impl.h - Issue 2728893004: Move WasUnableToDownload logic to FaviconHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_driver_impl.h

Issue 2728893004: Move WasUnableToDownload logic to FaviconHandler (Closed)

Patch Set: Reverted accidental changes. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_driver_impl.h

diff --git a/components/favicon/core/favicon_driver_impl.h b/components/favicon/core/favicon_driver_impl.h

index 7d33c3ef936cd5ef71c3cee4a1b2e21f6befe92f..190863670b17a6f08735e56833381c0a5b6ccc98 100644

--- a/components/favicon/core/favicon_driver_impl.h

+++ b/components/favicon/core/favicon_driver_impl.h

@@ -53,9 +53,6 @@ class FaviconDriverImpl : public FaviconDriver,

bookmarks::BookmarkModel* bookmark_model);

~FaviconDriverImpl() override;

- // Returns whether downloading favicon for |url| previously failed.

- bool WasUnableToDownloadFavicon(const GURL& url);

// Informs FaviconService that the favicon for |url| is out of date. If

// |force_reload| is true, then discard information about favicon download

// failures.