Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: components/favicon/core/favicon_handler.h

Issue 2728893004: Move WasUnableToDownload logic to FaviconHandler (Closed)
Patch Set: Addressed comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_handler.h
diff --git a/components/favicon/core/favicon_handler.h b/components/favicon/core/favicon_handler.h
index e7a13bbb8d08a03166d910ab0330d170854c488b..b99d3975c8cfb524921b37181296e5b576951970 100644
--- a/components/favicon/core/favicon_handler.h
+++ b/components/favicon/core/favicon_handler.h
@@ -253,6 +253,11 @@ class FaviconHandler {
const gfx::Image& image,
favicon_base::IconType icon_type);
+ // Considers the current candidate finished and can (a) stop working if an
+ // exact match was found or no candidates are left; or (b) increase
+ // |current_candidate_index_| and start processing the next candidate.
+ void CurrentCandidateFinished(bool found_exact_match);
+
// Notifies |driver_| that FaviconHandler found an icon which matches the
// |handler_type_| criteria. NotifyFaviconUpdated() can be called multiple
// times for the same page if:

Powered by Google App Engine
This is Rietveld 408576698