[wasm] Implement simd lowering for F32x4 and I32x4 compare ops

test/cctest/wasm/test-run-wasm-simd.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/assembler-inl.h"
 #include "src/wasm/wasm-macro-gen.h"
 #include "test/cctest/cctest.h"
 #include "test/cctest/compiler/value-helper.h"
 #include "test/cctest/wasm/wasm-run-utils.h"
 
@@ skipping 10 matching lines @@
 typedef int32_t (*Int32UnOp)(int32_t);
 typedef int32_t (*Int32BinOp)(int32_t, int32_t);
 typedef int32_t (*Int32ShiftOp)(int32_t, int);
 typedef int16_t (*Int16UnOp)(int16_t);
 typedef int16_t (*Int16BinOp)(int16_t, int16_t);
 typedef int16_t (*Int16ShiftOp)(int16_t, int);
 typedef int8_t (*Int8UnOp)(int8_t);
 typedef int8_t (*Int8BinOp)(int8_t, int8_t);
 typedef int8_t (*Int8ShiftOp)(int8_t, int);
 
-#if V8_TARGET_ARCH_ARM
-// Floating point specific value functions, only used by ARM so far.
+#if !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_X64
+#define SIMD_LOWERING_TARGET 1
+#else
+#define SIMD_LOWERING_TARGET 0
+#endif  // !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_X64
+
+#if V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
 int32_t Equal(float a, float b) { return a == b ? 1 : 0; }
 
 int32_t NotEqual(float a, float b) { return a != b ? 1 : 0; }
-#endif  // V8_TARGET_ARCH_ARM
+#endif  // V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
+
+#if SIMD_LOWERING_TARGET
+int32_t Less(float a, float b) { return a < b ? 1 : 0; }
+
+int32_t LessEqual(float a, float b) { return a <= b ? 1 : 0; }
+
+int32_t Greater(float a, float b) { return a > b ? 1 : 0; }
+
+int32_t GreaterEqual(float a, float b) { return a >= b ? 1 : 0; }
+#endif  // SIMD_LOWERING_TARGET
 
 // Generic expected value functions.
 template <typename T>
 T Negate(T a) {
   return -a;
 }
 
 template <typename T>
 T Add(T a, T b) {
   return a + b;
@@ skipping 165 matching lines @@
   return ~a;
 }
 
 template <typename T>
 T Sqrt(T a) {
   return std::sqrt(a);
 }
 
 }  // namespace
 
-#if !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_X64
-#define SIMD_LOWERING_TARGET 1
-#else
-#define SIMD_LOWERING_TARGET 0
-#endif  // !V8_TARGET_ARCH_ARM && !V8_TARGET_ARCH_X64
-
 #define WASM_SIMD_CHECK_LANE(TYPE, value, LANE_TYPE, lane_value, lane_index) \
   WASM_IF(WASM_##LANE_TYPE##_NE(WASM_GET_LOCAL(lane_value),                  \
                                 WASM_SIMD_##TYPE##_EXTRACT_LANE(             \
                                     lane_index, WASM_GET_LOCAL(value))),     \
           WASM_RETURN1(WASM_ZERO))
 
 #define WASM_SIMD_CHECK_F32_LANE(value, lane_value, lane_index)             \
   WASM_IF(WASM_F32_NE(WASM_GET_LOCAL(lane_value),                           \
                       WASM_SIMD_F32x4_EXTRACT_LANE(lane_index,              \
                                                    WASM_GET_LOCAL(value))), \
@@ skipping 242 matching lines @@
 WASM_EXEC_COMPILED_TEST(F32x4Mul) { RunF32x4BinOpTest(kExprF32x4Mul, Mul); }
 WASM_EXEC_COMPILED_TEST(F32x4Div) { RunF32x4BinOpTest(kExprF32x4Div, Div); }
 WASM_EXEC_COMPILED_TEST(Simd_F32x4_Min) {
   RunF32x4BinOpTest(kExprF32x4Min, Minimum);
 }
 WASM_EXEC_COMPILED_TEST(Simd_F32x4_Max) {
   RunF32x4BinOpTest(kExprF32x4Max, Maximum);
 }
 #endif  // SIMD_LOWERING_TARGET
 
-#if V8_TARGET_ARCH_ARM
+#if V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
 void RunF32x4CompareOpTest(WasmOpcode simd_op, FloatCompareOp expected_op) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t, float, float, int32_t> r(kExecuteCompiled);
   byte a = 0;
   byte b = 1;
   byte expected = 2;
   byte simd0 = r.AllocateLocal(kWasmS128);
   byte simd1 = r.AllocateLocal(kWasmS128);
   BUILD(r, WASM_SET_LOCAL(simd0, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(a))),
         WASM_SET_LOCAL(simd1, WASM_SIMD_F32x4_SPLAT(WASM_GET_LOCAL(b))),
@@ skipping 14 matching lines @@
   }
 }
 
 WASM_EXEC_COMPILED_TEST(F32x4Equal) {
   RunF32x4CompareOpTest(kExprF32x4Eq, Equal);
 }
 
 WASM_EXEC_COMPILED_TEST(F32x4NotEqual) {
   RunF32x4CompareOpTest(kExprF32x4Ne, NotEqual);
 }
-#endif  // V8_TARGET_ARCH_ARM
+#endif  // V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
+
+#if SIMD_LOWERING_TARGET
+WASM_EXEC_COMPILED_TEST(F32x4LessThan) {
+  RunF32x4CompareOpTest(kExprF32x4Lt, Less);
+}
+WASM_EXEC_COMPILED_TEST(F32x4LessThanOrEqual) {
+  RunF32x4CompareOpTest(kExprF32x4Le, LessEqual);
+}
+WASM_EXEC_COMPILED_TEST(F32x4GreaterThan) {
+  RunF32x4CompareOpTest(kExprF32x4Gt, Greater);
+}
+WASM_EXEC_COMPILED_TEST(F32x4GreaterThanOrEqual) {
+  RunF32x4CompareOpTest(kExprF32x4Ge, GreaterEqual);
+}
+#endif  // SIMD_LOWERING_TARGET
 
 WASM_EXEC_COMPILED_TEST(I32x4Splat) {
   FLAG_wasm_simd_prototype = true;
 
   // Store SIMD value in a local variable, use extract lane to check lane values
   // This test is not a test for ExtractLane as Splat does not create
   // interesting SIMD values.
   //
   // SetLocal(1, I32x4Splat(Local(0)));
   // For each lane index
@@ skipping 346 matching lines @@
   RunI32x4BinOpTest(kExprI32x4MaxS, Maximum);
 }
 
 WASM_EXEC_COMPILED_TEST(Ui32x4Min) {
   RunI32x4BinOpTest(kExprI32x4MinU, UnsignedMinimum);
 }
 
 WASM_EXEC_COMPILED_TEST(Ui32x4Max) {
   RunI32x4BinOpTest(kExprI32x4MaxU, UnsignedMaximum);
 }
-#endif  // V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
 
-#if V8_TARGET_ARCH_ARM
 void RunI32x4CompareOpTest(WasmOpcode simd_op, Int32BinOp expected_op) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t, int32_t, int32_t, int32_t> r(kExecuteCompiled);
   byte a = 0;
   byte b = 1;
   byte expected = 2;
   byte simd0 = r.AllocateLocal(kWasmS128);
   byte simd1 = r.AllocateLocal(kWasmS128);
   BUILD(r, WASM_SET_LOCAL(simd0, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(a))),
         WASM_SET_LOCAL(simd1, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(b))),
@@ skipping 40 matching lines @@
   RunI32x4CompareOpTest(kExprI32x4GeU, UnsignedGreaterEqual);
 }
 
 WASM_EXEC_COMPILED_TEST(Ui32x4Less) {
   RunI32x4CompareOpTest(kExprI32x4LtU, UnsignedLess);
 }
 
 WASM_EXEC_COMPILED_TEST(Ui32x4LessEqual) {
   RunI32x4CompareOpTest(kExprI32x4LeU, UnsignedLessEqual);
 }
-#endif  // V8_TARGET_ARCH_ARM
 
-#if V8_TARGET_ARCH_ARM || SIMD_LOWERING_TARGET
 void RunI32x4ShiftOpTest(WasmOpcode simd_op, Int32ShiftOp expected_op,
                          int shift) {
   FLAG_wasm_simd_prototype = true;
   WasmRunner<int32_t, int32_t, int32_t> r(kExecuteCompiled);
   byte a = 0;
   byte expected = 1;
   byte simd = r.AllocateLocal(kWasmS128);
   BUILD(r, WASM_SET_LOCAL(simd, WASM_SIMD_I32x4_SPLAT(WASM_GET_LOCAL(a))),
         WASM_SET_LOCAL(
             simd, WASM_SIMD_SHIFT_OP(simd_op, shift, WASM_GET_LOCAL(simd))),
@@ skipping 603 matching lines @@
         WASM_SET_GLOBAL(0, WASM_SIMD_F32x4_REPLACE_LANE(3, WASM_GET_GLOBAL(0),
                                                         WASM_F32(65.0))),
         WASM_I32V(1));
   FOR_INT32_INPUTS(i) { CHECK_EQ(1, r.Call(0)); }
   CHECK_EQ(*global, 13.5);
   CHECK_EQ(*(global + 1), 45.5);
   CHECK_EQ(*(global + 2), 32.25);
   CHECK_EQ(*(global + 3), 65.0);
 }
 #endif  // SIMD_LOWERING_TARGET