Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: ash/display/display_configuration_controller_unittest.cc

Issue 2728803002: Handles users rotating screen too early (Closed)
Patch Set: Rebased, reset is_rotating in layerCleanupObserver etc. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/display/display_configuration_controller_unittest.cc
diff --git a/ash/display/display_configuration_controller_unittest.cc b/ash/display/display_configuration_controller_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b0a5ada8ce16228e613fa9639bf5fe71936b2d08
--- /dev/null
+++ b/ash/display/display_configuration_controller_unittest.cc
@@ -0,0 +1,43 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/common/wm_shell.h"
+#include "ash/rotator/screen_rotation_animator.h"
+#include "ash/shell.h"
+#include "ash/test/ash_test_base.h"
+#include "ash/test/display_configuration_controller_test_api.h"
+
+namespace ash {
+namespace test {
+
+class DisplayConfigurationControllerTest : public AshTestBase {
+ public:
+ DisplayConfigurationControllerTest() {}
+ ~DisplayConfigurationControllerTest() override {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(DisplayConfigurationControllerTest);
bruthig 2017/03/08 22:35:59 Missing "#include base/macros.h" for DISALLOW_COPY
wutao 2017/03/09 22:09:19 Done.
+};
+
+TEST_F(DisplayConfigurationControllerTest, ErasesAnimatorOnAnimationEnded) {
+ // TODO(wutao): needs display_configuration_controller.
+ if (WmShell::Get()->IsRunningInMash())
+ return;
+
+ display::Display display = display::Screen::GetScreen()->GetPrimaryDisplay();
+ DisplayConfigurationControllerTestApi testapi(
+ Shell::GetInstance()->display_configuration_controller());
+ ScreenRotationAnimator* screen_rotation_animator =
+ testapi.GetScreenRotationAnimatorForDisplay(display.id());
+ EXPECT_EQ(1, testapi.DisplayScreenRotationAnimatorMapSize());
+
+ display.set_rotation(display::Display::ROTATE_0);
+ screen_rotation_animator->Rotate(
+ display::Display::ROTATE_90,
+ display::Display::RotationSource::ROTATION_SOURCE_USER);
+ EXPECT_EQ(0, testapi.DisplayScreenRotationAnimatorMapSize());
+}
+
+} // namespace test
+} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698