Issue 2728773004: Undo publication of default popular sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2728773004: Undo publication of default popular sites (Closed)

Created:
3 years, 9 months ago by fhorschig

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Undo publication of default popular sites Closed as there is a flag to disable that behavior: https://crrev.com/2741413008 In case we don't get launch approval, this CL will disable popular sites using default lists. BUG=672939

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	components/ntp_tiles/popular_sites_impl.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	M	components/ntp_tiles/popular_sites_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2695713004 Patch 420001

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

fhorschig

3 years, 9 months ago (2017-03-17 10:33:45 UTC) #2

Description was changed from

==========
Undo publication of default popular sites

In case we don't get launch approval, this CL will disable popular
sites using default lists.

BUG=672939
==========

to

==========
Undo publication of default popular sites

Closed as there is a flag to disable that behavior: 
https://crrev.com/2741413008

In case we don't get launch approval, this CL will disable popular
sites using default lists.

BUG=672939
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages