Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/feedback/html/default.html

Issue 2728773003: Make email field in Feedback app uneditable (Closed)
Patch Set: More nits Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/feedback/css/feedback.css ('k') | chrome/browser/resources/feedback/js/feedback.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/feedback/html/default.html
diff --git a/chrome/browser/resources/feedback/html/default.html b/chrome/browser/resources/feedback/html/default.html
index 00f412b68ccaa0b5ca86444b0e331ecf6300abed..5b03af1326a503eb164299dabf05ee6ccc000f1d 100644
--- a/chrome/browser/resources/feedback/html/default.html
+++ b/chrome/browser/resources/feedback/html/default.html
@@ -19,9 +19,11 @@
<div id="title-bar" class="title-bar">
<span id="page-title" i18n-content="page-title"></span>
<span class="topbutton-bar">
- <button class="minimize-button" id="minimize-button" tabindex="-1">
+ <button class="minimize-button" id="minimize-button" tabindex="-1"
+ i18n-values="aria-label:minimize-btn-label">
</button>
- <button class="close-button" id="close-button" tabindex="-1">
+ <button class="close-button" id="close-button" tabindex="-1"
+ i18n-values="aria-label:close-btn-label">
</button>
</span>
</div>
@@ -49,7 +51,10 @@
<!-- User e-mail -->
<div id="user-email" class="text-field-container">
<label id="user-email-label" i18n-content="user-email"></label>
- <input id="user-email-text" aria-labelledby="user-email-label" type="text">
+ <select id="user-email-drop-down" aria-labelledby="user-email-label">
+ <option id="anonymous-user-option" value="anonymous_user"
+ i18n-content="anonymous-user"></option>
+ </select>
</div>
<!-- Attach a file -->
<div id="attach-file-container" class="text-field-container">
« no previous file with comments | « chrome/browser/resources/feedback/css/feedback.css ('k') | chrome/browser/resources/feedback/js/feedback.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698