Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: chrome/browser/resources/feedback/js/feedback.js

Issue 2728773003: Make email field in Feedback app uneditable (Closed)
Patch Set: Fix test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback/js/feedback.js
diff --git a/chrome/browser/resources/feedback/js/feedback.js b/chrome/browser/resources/feedback/js/feedback.js
index 6d06cc7b812bf8418dbb35989fc5dd0e1e8bafd4..0ba026e8116a2adbe30ab9cba45175d8eb5ef6fc 100644
--- a/chrome/browser/resources/feedback/js/feedback.js
+++ b/chrome/browser/resources/feedback/js/feedback.js
@@ -51,6 +51,11 @@ var SYSINFO_WINDOW_ID = 'sysinfo_window';
*/
var STATS_WINDOW_ID = 'stats_window';
+/** @type {string}
+ * @const
+ */
+var ANONYMOUS_USER_OPTION_VALUE = 'anonymous_user';
xiyuan 2017/03/02 18:55:11 nit: not used?
afakhry 2017/03/02 19:04:47 Yes, not anymore, forgot to remove it. Done.
+
/**
* SRT Prompt Result defined in feedback_private.idl.
* @enum {string}
@@ -166,7 +171,8 @@ function sendReport() {
feedbackInfo.description = $('description-text').value;
feedbackInfo.pageUrl = $('page-url-text').value;
- feedbackInfo.email = $('user-email-text').value;
+ var emailDropDown = $('user-email-drop-down');
+ feedbackInfo.email = emailDropDown.options[emailDropDown.selectedIndex].value;
xiyuan 2017/03/02 18:55:11 nit: get rid of |emailDropDown| and use $('user-em
afakhry 2017/03/02 19:04:47 The line would be too long, but done anyway.
var useSystemInfo = false;
var useHistograms = false;
@@ -344,7 +350,13 @@ function initialize() {
});
chrome.feedbackPrivate.getUserEmail(function(email) {
- $('user-email-text').value = email;
+ var optionElement = document.createElement('option');
+ optionElement.value = email;
+ optionElement.text = email;
+ optionElement.selected = true;
+ var dropDown = $('user-email-drop-down');
+ // Make sure the "Report anonymously" option comes last.
+ dropDown.insertBefore(optionElement, dropDown.firstChild);
xiyuan 2017/03/02 18:55:11 nit: get rid of |dropDown|
afakhry 2017/03/02 19:04:47 Done.
});
// Initiate getting the system info.

Powered by Google App Engine
This is Rietveld 408576698