Make email field in Feedback app uneditable

chrome/browser/resources/feedback/js/feedback.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @type {string}
  * @const
  */
 var SRT_DOWNLOAD_PAGE = 'https://www.google.com/chrome/cleanup-tool/';
 
@@ skipping 148 matching lines @@
   // Prevent double clicking from sending additional reports.
   $('send-report-button').disabled = true;
   console.log('Feedback: Sending report');
   if (!feedbackInfo.attachedFile && attachedFileBlob) {
     feedbackInfo.attachedFile = { name: $('attach-file').value,
                                   data: attachedFileBlob };
   }
 
   feedbackInfo.description = $('description-text').value;
   feedbackInfo.pageUrl = $('page-url-text').value;
-  feedbackInfo.email = $('user-email-text').value;
+  feedbackInfo.email =
+      $('user-email-drop-down').options[

[xiyuan, 2017/03/02 19:23:33]

feedbackInfo.email = $('user-email-drop-down').value;

[afakhry, 2017/03/02 19:56:05]

Oh, I didn't know we could do that!

Done.

+          $('user-email-drop-down').selectedIndex].value;
 
   var useSystemInfo = false;
   var useHistograms = false;
   if ($('sys-info-checkbox') != null &&
       $('sys-info-checkbox').checked) {
     // Send histograms along with system info.
     useSystemInfo = useHistograms = true;
   }
 // <if expr="chromeos">
   if ($('performance-info-checkbox') == null ||
@@ skipping 157 matching lines @@
         chrome.app.window.current().show();
 
         var screenshotDataUrl = screenshotCanvas.toDataURL('image/png');
         $('screenshot-image').src = screenshotDataUrl;
         $('screenshot-image').classList.toggle('wide-screen',
             $('screenshot-image').width > MAX_SCREENSHOT_WIDTH);
         feedbackInfo.screenshot = dataUrlToBlob(screenshotDataUrl);
       });
 
       chrome.feedbackPrivate.getUserEmail(function(email) {
-        $('user-email-text').value = email;
+        var optionElement = document.createElement('option');
+        optionElement.value = email;
+        optionElement.text = email;
+        optionElement.selected = true;
+        // Make sure the "Report anonymously" option comes last.
+        $('user-email-drop-down').insertBefore(
+            optionElement, $('user-email-drop-down').firstChild);

[xiyuan, 2017/03/02 19:23:33]

oops, did not realized that $('user-email-drop-down') is used twice. In this
case, we should use a var like you had before. :p

Or use $('anonymous-user-option').

[afakhry, 2017/03/02 19:56:05]

Using the $('anonymous-user-option') instead.

       });
 
       // Initiate getting the system info.
       isSystemInfoReady = false;
       getSystemInformation(onSystemInformation);
 
       // An extension called us with an attached file.
       if (feedbackInfo.attachedFile) {
         $('attached-filename-text').textContent =
             feedbackInfo.attachedFile.name;
@@ skipping 80 matching lines @@
     $('cancel-button').onclick = cancel;
     $('remove-attached-file').onclick = clearAttachedFile;
 // <if expr="chromeos">
     $('performance-info-checkbox').addEventListener(
         'change', performanceFeedbackChanged);
 // </if>
   });
 }
 
 initialize();