Make email field in Feedback app uneditable

chrome/browser/resources/feedback/js/feedback.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @type {string}
  * @const
  */
 var SRT_DOWNLOAD_PAGE = 'https://www.google.com/chrome/cleanup-tool/';
 
@@ skipping 33 matching lines @@
 /** @type {string}
  * @const
  */
 var SYSINFO_WINDOW_ID = 'sysinfo_window';
 
 /** @type {string}
  * @const
  */
 var STATS_WINDOW_ID = 'stats_window';
 
+/** @type {string}
+ * @const
+ */
+var ANONYMOUS_USER_OPTION_VALUE = 'anonymous_user';

[xiyuan, 2017/03/02 18:55:11]

nit: not used?

[afakhry, 2017/03/02 19:04:47]

Yes, not anymore, forgot to remove it. Done.

+
 /**
  * SRT Prompt Result defined in feedback_private.idl.
  * @enum {string}
  */
 var SrtPromptResult = {
   ACCEPTED: 'accepted',  // User accepted prompt.
   DECLINED: 'declined',  // User declined prompt.
   CLOSED: 'closed',      // User closed window without responding to prompt.
 };
 
@@ skipping 95 matching lines @@
   // Prevent double clicking from sending additional reports.
   $('send-report-button').disabled = true;
   console.log('Feedback: Sending report');
   if (!feedbackInfo.attachedFile && attachedFileBlob) {
     feedbackInfo.attachedFile = { name: $('attach-file').value,
                                   data: attachedFileBlob };
   }
 
   feedbackInfo.description = $('description-text').value;
   feedbackInfo.pageUrl = $('page-url-text').value;
-  feedbackInfo.email = $('user-email-text').value;
+  var emailDropDown = $('user-email-drop-down');
+  feedbackInfo.email = emailDropDown.options[emailDropDown.selectedIndex].value;

[xiyuan, 2017/03/02 18:55:11]

nit: get rid of |emailDropDown| and use $('user-email-drop-down') in place

[afakhry, 2017/03/02 19:04:47]

The line would be too long, but done anyway.

 
   var useSystemInfo = false;
   var useHistograms = false;
   if ($('sys-info-checkbox') != null &&
       $('sys-info-checkbox').checked) {
     // Send histograms along with system info.
     useSystemInfo = useHistograms = true;
   }
 // <if expr="chromeos">
   if ($('performance-info-checkbox') == null ||
@@ skipping 157 matching lines @@
         chrome.app.window.current().show();
 
         var screenshotDataUrl = screenshotCanvas.toDataURL('image/png');
         $('screenshot-image').src = screenshotDataUrl;
         $('screenshot-image').classList.toggle('wide-screen',
             $('screenshot-image').width > MAX_SCREENSHOT_WIDTH);
         feedbackInfo.screenshot = dataUrlToBlob(screenshotDataUrl);
       });
 
       chrome.feedbackPrivate.getUserEmail(function(email) {
-        $('user-email-text').value = email;
+        var optionElement = document.createElement('option');
+        optionElement.value = email;
+        optionElement.text = email;
+        optionElement.selected = true;
+        var dropDown = $('user-email-drop-down');
+        // Make sure the "Report anonymously" option comes last.
+        dropDown.insertBefore(optionElement, dropDown.firstChild);

[xiyuan, 2017/03/02 18:55:11]

nit: get rid of |dropDown|

[afakhry, 2017/03/02 19:04:47]

Done.

       });
 
       // Initiate getting the system info.
       isSystemInfoReady = false;
       getSystemInformation(onSystemInformation);
 
       // An extension called us with an attached file.
       if (feedbackInfo.attachedFile) {
         $('attached-filename-text').textContent =
             feedbackInfo.attachedFile.name;
@@ skipping 80 matching lines @@
     $('cancel-button').onclick = cancel;
     $('remove-attached-file').onclick = clearAttachedFile;
 // <if expr="chromeos">
     $('performance-info-checkbox').addEventListener(
         'change', performanceFeedbackChanged);
 // </if>
   });
 }
 
 initialize();