Fix parsing [a]sync[*] function body modifiers with Fasta.

Fix parsing [a]sync[*] function body modifiers with Fasta.

The Fasta'a parser is crazy as it is now. It says that something is a
return statement, but it is actually an expression function body. That
seems too much dart2js specific.

R=paulberry@google.com, ahe@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/ce58e89d3cd5410a6786922460f26fc3c8971582

[Paul Berry, 2017-03-01 22:42:55]

https://codereview.chromium.org/2728773002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2728773002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:548: bool asExpressionBody,
bool hasExpression, Token beginToken,
Rather than add a boolean parameter to endReturnStatement(), would it be cleaner
to add a new method endExpressionFunctionBody()?  Dart2js's implementation of
endExpressionFunctionBody() could just call endReturnStatement(); AstBuilder's
could handle it as a completely independent construct.

[scheglov, 2017-03-01 23:04:49]

PTAL

https://codereview.chromium.org/2728773002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/listener.dart (right):

https://codereview.chromium.org/2728773002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/listener.dart:548: bool asExpressionBody,
bool hasExpression, Token beginToken,
On 2017/03/01 22:42:55, Paul Berry wrote:
> Rather than add a boolean parameter to endReturnStatement(), would it be
cleaner
> to add a new method endExpressionFunctionBody()?  Dart2js's implementation of
> endExpressionFunctionBody() could just call endReturnStatement(); AstBuilder's
> could handle it as a completely independent construct.

Done.

[Paul Berry, 2017-03-01 23:08:50]

lgtm

[scheglov, 2017-03-02 00:20:26]

Description was changed from

==========
Fix parsing [a]sync[*] function body modifiers with Fasta.

The Fasta'a parser is crazy as it is now. It says that something is a
return statement, but it is actually an expression function body. That
seems too much dart2js specific.

R=ahe@google.com, paulberry@google.com
BUG=
==========

to

==========
Fix parsing [a]sync[*] function body modifiers with Fasta.

The Fasta'a parser is crazy as it is now. It says that something is a
return statement, but it is actually an expression function body. That
seems too much dart2js specific.

R=paulberry@google.com, ahe@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/ce58e89d3cd5410a6786922460f26fc3c8971582
==========

[scheglov, 2017-03-02 00:20:27]

Committed patchset #2 (id:20001) manually as
ce58e89d3cd5410a6786922460f26fc3c8971582 (presubmit successful).

[ahe, 2017-03-02 07:17:27]

lgtm

Nice!