Migrate some case conversion functions from JS to CPP builtins

src/builtins/builtins.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BUILTINS_BUILTINS_H_
 #define V8_BUILTINS_BUILTINS_H_
 
 #include "src/base/flags.h"
 #include "src/globals.h"
 
@@ skipping 33 matching lines @@
 //      Args: name, arguments count
 // TFS: Builtin in Turbofan, with CodeStub linkage.
 //      Args: name, code kind, extra IC state, interface descriptor, return_size
 // ASM: Builtin in platform-dependent assembly.
 //      Args: name
 // ASH: Handlers implemented in platform-dependent assembly.
 //      Args: name, code kind, extra IC state
 // DBG: Builtin in platform-dependent assembly, used by the debugger.
 //      Args: name
 
-#define BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG)                        \
+#define BUILTIN_LIST_BASE(CPP, API, TFJ, TFS, ASM, ASH, DBG)                   \
   ASM(Abort)                                                                   \
   /* Code aging */                                                             \
   CODE_AGE_LIST_WITH_ARG(DECLARE_CODE_AGE_BUILTIN, ASM)                        \
                                                                                \
   /* Declared first for dependency reasons */                                  \
   ASM(CompileLazy)                                                             \
   TFS(ToObject, BUILTIN, kNoExtraICState, TypeConversion, 1)                   \
   TFS(FastNewObject, BUILTIN, kNoExtraICState, FastNewObject, 1)               \
   TFS(HasProperty, BUILTIN, kNoExtraICState, HasProperty, 1)                   \
                                                                                \
@@ skipping 719 matching lines @@
   TFJ(StringPrototypeSplit, 2)                                                 \
   /* ES6 section B.2.3.1 String.prototype.substr ( start, length ) */          \
   TFJ(StringPrototypeSubstr, 2)                                                \
   /* ES6 section 21.1.3.19 String.prototype.substring ( start, end ) */        \
   TFJ(StringPrototypeSubstring, 2)                                             \
   /* ES6 section 21.1.3.20 */                                                  \
   /* String.prototype.startsWith ( searchString [ , position ] ) */            \
   CPP(StringPrototypeStartsWith)                                               \
   /* ES6 section 21.1.3.25 String.prototype.toString () */                     \
   TFJ(StringPrototypeToString, 0)                                              \
-  /* ES #sec-string.prototype.tolocalelowercase */                             \
+  /* (obsolete) Unibrow string functions */                                    \
   CPP(StringPrototypeToLocaleLowerCase)                                        \
-  /* ES #sec-string.prototype.tolocaleuppercase */                             \
   CPP(StringPrototypeToLocaleUpperCase)                                        \
-  /* ES #sec-string.prototype.tolowercase */                                   \
   CPP(StringPrototypeToLowerCase)                                              \
-  /* ES #sec-string.prototype.touppercase */                                   \
   CPP(StringPrototypeToUpperCase)                                              \
   CPP(StringPrototypeTrim)                                                     \
   CPP(StringPrototypeTrimLeft)                                                 \
   CPP(StringPrototypeTrimRight)                                                \
   /* ES6 section 21.1.3.28 String.prototype.valueOf () */                      \
   TFJ(StringPrototypeValueOf, 0)                                               \
   /* ES6 #sec-string.prototype-@@iterator */                                   \
   TFJ(StringPrototypeIterator, 0)                                              \
                                                                                \
   /* StringIterator */                                                         \
@@ skipping 58 matching lines @@
                                                                                \
   /* %AsyncFromSyncIteratorPrototype% */                                       \
   /* (proposal-async-iteration/#sec-%asyncfromsynciteratorprototype%-object)*/ \
   TFJ(AsyncFromSyncIteratorPrototypeNext, 1)                                   \
   TFJ(AsyncFromSyncIteratorPrototypeThrow, 1)                                  \
   TFJ(AsyncFromSyncIteratorPrototypeReturn, 1)                                 \
                                                                                \
   /* proposal-async-iteration/#sec-async-iterator-value-unwrap-functions */    \
   TFJ(AsyncIteratorValueUnwrap, 1)
 
+#ifdef V8_I18N_SUPPORT
+#define BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG)          \
+  BUILTIN_LIST_BASE(CPP, API, TFJ, TFS, ASM, ASH, DBG)           \
+                                                                 \
+  /* TODO(jwolfe): implement the *Locale* variants like below */ \
+  /* ES #sec-string.prototype.tolocalelowercase */               \
+  /* CPP(StringPrototypeToLocaleLowerCaseI18N) */                \
+  /* ES #sec-string.prototype.tolocaleuppercase */               \
+  /* CPP(StringPrototypeToLocaleUpperCaseI18N) */                \

[Dan Ehrenberg, 2017/03/21 09:31:17]

Nit: Could you not check in these lines? I think this sort of thing would be
better handled in the bug tracker, or in a single-line TODO rather than all this
commented-out code.

+  /* ES #sec-string.prototype.tolowercase */                     \
+  CPP(StringPrototypeToLowerCaseI18N)                            \
+  /* ES #sec-string.prototype.touppercase */                     \
+  CPP(StringPrototypeToUpperCaseI18N)
+#else
+#define BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG) \
+  BUILTIN_LIST_BASE(CPP, API, TFJ, TFS, ASM, ASH, DBG)
+#endif  // V8_I18N_SUPPORT
+
 #define BUILTIN_PROMISE_REJECTION_PREDICTION_LIST(V) \
   V(AsyncFromSyncIteratorPrototypeNext)              \
   V(AsyncFromSyncIteratorPrototypeReturn)            \
   V(AsyncFromSyncIteratorPrototypeThrow)             \
   V(AsyncFunctionAwaitCaught)                        \
   V(AsyncFunctionAwaitUncaught)                      \
   V(PromiseConstructor)                              \
   V(PromiseHandle)                                   \
   V(PromiseResolve)                                  \
   V(PromiseResolveClosure)                           \
@@ skipping 153 matching lines @@
 
   friend class Isolate;
 
   DISALLOW_COPY_AND_ASSIGN(Builtins);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_BUILTINS_BUILTINS_H_