Issue 272873002: Cast: Fix encoding event subscriber log packet size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 272873002: Cast: Fix encoding event subscriber log packet size. (Closed)

Created:
6 years, 7 months ago by imcheng

Modified:
6 years, 7 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, jshin+watch_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Cast: Fix encoding event subscriber log packet size. Previously we set the packet size in BasePacketEvent proto during construction and never overwrite it. The problem is that the proto is most often created as a result of seeing a receiver packet event first, which does not contain packet size information and thus the size field is set to 0. We'd need to overwrite the size field when we see a sender packet event, which contains packet size information. Most of the time we see receiver event first because they often arrive sooner (via RTCP packets) than sender events (via IPC every second). BUG=373418 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269513