Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2728683005: Set dartAsyncMarker the same as asyncMarker unless explicitly set (Closed)

Created:
3 years, 9 months ago by jensj
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set dartAsyncMarker the same as asyncMarker unless explicitly set R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/89b68e905b6a096148cedc580016a595e106dcdd

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -84 lines) Patch
M pkg/kernel/lib/ast.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 14 chunks +0 lines, -38 lines 0 comments Download
M tests/language/language_kernel.status View 17 chunks +3 lines, -44 lines 0 comments Download
M tests/language/vm/causal_async_exception_stack_test.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jensj
3 new language tests fail --- seemingly because they mistakenly didn't fail before.
3 years, 9 months ago (2017-03-02 09:44:59 UTC) #2
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/2728683005/diff/1/pkg/kernel/lib/ast.dart File pkg/kernel/lib/ast.dart (right): https://codereview.chromium.org/2728683005/diff/1/pkg/kernel/lib/ast.dart#newcode1272 pkg/kernel/lib/ast.dart:1272: if (dartAsyncMarker == null) { dartAsyncMarker ??= asyncMarker;
3 years, 9 months ago (2017-03-02 10:10:27 UTC) #3
jensj
3 years, 9 months ago (2017-03-02 10:13:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
89b68e905b6a096148cedc580016a595e106dcdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698