Default arg support continued (flutter-intellij#553).

Default arg support continued (flutter-intellij#553).

Default arg support for:
  * inherited refs
  * imported refs
  * type members
  * local constructors

BUG=
R=brianwilkerson@google.com, scheglov@google.com

See: https://github.com/flutter/flutter-intellij/issues/553
Committed: https://github.com/dart-lang/sdk/commit/d826b1f931fed635761ce76112ac8573de3b313d

[pquitslund, 2017-03-01 21:38:51]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2017-03-01 21:43:54]

lgtm

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/utilities.dart:36: String
buildDefaultArgList(Iterable<ParameterElement> requiredParams,
It seems to me that we could pass here the whole list of parameter elements and
perform handling required/named in the method. So, we could avoid duplicating
this code.

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart:4525:
// Sanity check.  Permutations tested in local_ref_contributor.
///

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart:627:
// Sanity check.  Permutations tested in local_ref_contributor.
///

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart:4157:
// Sanity check.  Permutations tested in local_ref_contributor.
///

[Brian Wilkerson, 2017-03-01 22:01:35]

lgtm

[pquitslund, 2017-03-01 22:59:25]

Thanks!

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/completion/dart/utilities.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/utilities.dart:36: String
buildDefaultArgList(Iterable<ParameterElement> requiredParams,
On 2017/03/01 21:43:54, scheglov wrote:
> It seems to me that we could pass here the whole list of parameter elements
and
> perform handling required/named in the method. So, we could avoid duplicating
> this code.

I'll look at improving this in the next round.

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart:4525:
// Sanity check.  Permutations tested in local_ref_contributor.
On 2017/03/01 21:43:54, scheglov wrote:
> ///

Done.

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart:627:
// Sanity check.  Permutations tested in local_ref_contributor.
On 2017/03/01 21:43:54, scheglov wrote:
> ///

Done.

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
File
pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart
(right):

https://codereview.chromium.org/2728653004/diff/1/pkg/analysis_server/test/se...
pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart:4157:
// Sanity check.  Permutations tested in local_ref_contributor.
On 2017/03/01 21:43:54, scheglov wrote:
> ///

Done.

[pquitslund, 2017-03-01 23:00:54]

Description was changed from

==========
Default arg support continued (flutter-intellij#553).

Default arg support for:
  * inherited refs
  * imported refs
  * type members
  * local constructors

BUG=

See: https://github.com/flutter/flutter-intellij/issues/553
==========

to

==========
Default arg support continued (flutter-intellij#553).

Default arg support for:
  * inherited refs
  * imported refs
  * type members
  * local constructors

BUG=
R=brianwilkerson@google.com, scheglov@google.com

See: https://github.com/flutter/flutter-intellij/issues/553
Committed:
https://github.com/dart-lang/sdk/commit/d826b1f931fed635761ce76112ac8573de3b313d
==========

[pquitslund, 2017-03-01 23:00:55]

Committed patchset #2 (id:20001) manually as
d826b1f931fed635761ce76112ac8573de3b313d (presubmit successful).